Security Check

[Andi]

Hi

I found that calendar.php is vulnerable to XSS.

for simple sample:
http://pragma.cjb.net/dev-Coppermine/devel/calendar.php?action=banning&month=2&year=%3Cscript%3Ealert('Hallo%20:-))')%3C/script%3E

simple solution:
change line #80-81 to

Code Select Expand

$month = intval($_REQUEST['month']);
$year = intval($_REQUEST['year']);


[omniscientdeveloper]

I made these changes:

Code Select Expand


$today = getdate();

$month = (int) $_REQUEST['month'];
$year = (int) $_REQUEST['year'];

if ($year == 0) {
    $year = $today['year'];
}

if ($month == 0) {
    $month = $today['mon'];
}


It prevents it on my setup.

[Andi]

 

that's the better solution