some small errors in calendar.php some small errors in calendar.php
 

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Main Menu

some small errors in calendar.php

Started by Andi, February 07, 2005, 01:51:07 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Print
Go Down Pages1
User actions

Andi

February 07, 2005, 01:51:07 AM Last Edit: February 20, 2005, 05:55:47 PM by GauGau
Hello :)

in file
  Coppermine version: 1.4.1
  $Source: /cvsroot/coppermine/devel/calendar.php,v $
  $Revision: 1.7 $
  $Author: nibbler999 $
  $Date: 2005/01/14 14:11:01 $

this code:
Code Select
<link rel="stylesheet" href="themes/
<?php
if ($USER['theme']) {
    print $USER['theme'];
} else {
    print $CONFIG['theme'];
}
?>
/style.css" />

makes a linebreak after themes/ and the stylesheet does not load.

I've change this Lines to:
Code Select
<link href="themes/<?= $CONFIG['theme'] ?>/style.css" rel="stylesheet" type="text/css">


And in line #74, this code:
Code Select
        return "$s?action=".$_REQUEST['action']."&month=$month&year=$year";
should be:
Code Select
        return "$s?action=".$_REQUEST['action']."&amp;month=$month&amp;year=$year";


And html-Validator says "missing doctype declaration"  ;)
hope, I could help you... :)

kegobeer

#1
February 07, 2005, 02:39:13 AM
Doesn't your change completely remove the user theme option?  Wouldn't it be more appropriate to use this:

Code Select
echo '<link rel="stylesheet" href="themes/' . ($USER['theme'] ? $USER['theme'] : $CONFIG['theme']) . '/style.css" />';
Do not send me a private message unless I ask for one.  Make your post public so everyone can benefit.

There are no stupid questions
But there are a LOT of inquisitive idiots

Andi

#2
February 07, 2005, 08:46:33 AM
Hi :)

no, i think in cpg 1.4.x it's no problem.
The setting $CONFIG['theme'] is redeclared in init.inc.php, in dependence of the user attitude:

Code Select
// Load theme file
if (isset($USER['theme']) && !strstr($USER['theme'], '/') && is_dir(UDB_CPG_DIR.'themes/' . $USER['theme'])) {
    $CONFIG['theme'] = strtr($USER['theme'], '$/\\:*?"\'<>|`', '____________');
} else {
    unset($USER['theme']);
}
hope, I could help you... :)

Joachim Müller

#3
February 18, 2005, 05:20:11 PM
self-assign, will commit shortly.

Joachim

Joachim Müller

#4
February 19, 2005, 07:46:24 AM
done, please confirm.

Joachim

Andi

#5
February 19, 2005, 01:22:33 PM
Ok, it works fine :)

one small thing:
the <html> End-Tag is missing in this file
hope, I could help you... :)

Joachim Müller

#6
February 20, 2005, 05:55:13 PM
added missing </html>-tag. Marking as fixed. Thanks for your great bug reports!

Joachim
Print
Go Up Pages1
User actions