News:

CPG Release 1.6.29
During HTML5 upload, keep pseudo blank code 200 messages from triggering error condition
added Russian language
correct failure to use theme menu icons in album manager
minor vulnerabilities mitigation

Main Menu

Ending input tag brackets in several files

Started by kaptainkory, August 05, 2005, 11:56:33 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

kaptainkory

In albmgr.php, FIND (line 357):

        <input type="hidden" name="delete_album" value="">
        <input type="hidden" name="sort_order" value="<?php echo $sort_order ?>">


REPLACE WITH:

        <input type="hidden" name="delete_album" value="" />
        <input type="hidden" name="sort_order" value="<?php echo $sort_order ?>" />


FIND (line 421):

                                <input type="text" name="album_nm" size="27" maxlength="80" class="textinput" style="width: 300px;" onChange="Album_NameChange(this.value);" onKeyUp="Album_NameChange(this.value);">

REPLACE WITH:

                                <input type="text" name="album_nm" size="27" maxlength="80" class="textinput" style="width: 300px;" onChange="Album_NameChange(this.value);" onKeyUp="Album_NameChange(this.value);" />

FIND (line 431):

        <input type="submit" class="button" value="<?php echo $lang_albmgr_php['apply_modifs'?>">

REPLACE WITH:

        <input type="submit" class="button" value="<?php echo $lang_albmgr_php['apply_modifs'?>" />

In catmgr.php, FIND (line 131):

                        <input type="hidden" name="thumb" value="0">

REPLACE WITH:

                        <input type="hidden" name="thumb" value="0" />

FIND (line 434):

        <input type="hidden" name="cid" value ="{$current_category['cid']}">

REPLACE WITH:

        <input type="hidden" name="cid" value ="{$current_category['cid']}" />

FIND (line 448):

                <input type="text" style="width: 100%" name="name" value="{$current_category['name']}" class="textinput">

REPLACE WITH:

                <input type="text" style="width: 100%" name="name" value="{$current_category['name']}" class="textinput" />

FIND (line 466):

                <input type="submit" value="{$lang_catmgr_php['update_create']}" class="button">

REPLACE WITH:

                <input type="submit" value="{$lang_catmgr_php['update_create']}" class="button" />


The pattern continues for the following files and lines:

banning.php: 79, 80, 83, 90, 92, 301, 329

charsetmgr.php: 195, 196

db_card.php: 238, 252, 253, 256, 257

ecard.php: 48, 228, 248, 256, 265, 286, 288

editpics.php: 228, 273, 274, 275, 276, 277, 294, 304, 619

groupmgr.php: 76, 373, 384, 385, 388

image_processor.php: 637-648, 653-656, 658, 955-965, 971

install.php: 231, 259, 306, 313, 320, 335, 342, 349, 356, 363, 379, 384, 411-412 (ending brackets missing completely!), 413

keywordmgr.php: 88-89

minibrowser.php: 249-250

modifyalb.php: 95, 107, 121, 123, 142, 205, 303, 320, 331, 499-500, 550-551, 565, 591, 597 (ending bracket missing completely!)


Whew, okay, I'm tired.  There are more to fix, but just search for "<input " in the following files to find the rest:

picEditor.php, picmgr.php, register.php, relocate_server.php, report_file.php, searchnew.php, xp_publish.php, update.inc.php



Thanks.

Joachim Müller

thanks for your suggestions. Committed to cvs.