Missing part of HMTL for input_box_no_smilies Missing part of HMTL for input_box_no_smilies
 

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Main Menu

Missing part of HMTL for input_box_no_smilies

Started by kaptainkory, July 28, 2005, 07:28:03 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

kaptainkory

themes.inc.php

FIND (Line 857):

<!-- BEGIN input_box_no_smilies -->
                                <input type="text" class="textinput" id="message" name="msg_body"  maxlength="{MAX_COM_LENGTH}" style="width: 100%;" />


REPLACE WITH:

<!-- BEGIN input_box_no_smilies -->
                                <td class="tableb_compact">
                                <input type="text" class="textinput" id="message" name="msg_body"  maxlength="{MAX_COM_LENGTH}" style="width: 100%;" />


Thanks.

Joachim Müller

Bug confirmed. Suggested fix committed to cvs. Thanks for the contribution.

Joachim

kaptainkory

I've attached a picture of the output I get now.  Plus, I get a string of HTML Validator warnings that starts with "line 341 column 33 - Warning: <input> isn't allowed in <tr> elements", then "line 352 column 33 - Warning: discarding unexpected </td>", then "line 353 column 33 - Warning: missing <tr>", etc.

So, the table cells are still malformed it appears.

Joachim Müller

this is not what I get. Please post a deep link to your site.

kaptainkory

Hmm, I just pulled up the latest version of themes.inc.php (1.40).  It doesn't look like the change was committed to CSV.  Lines 857-858 read just like they did before; no <td> tag was added.  Did you make this correction exactly as suggested or in another way?

Thanks.

Joachim Müller

in another way. I'll re-check as soon as I'm on the machine that has the CVS software installed, maybe something went wrong with my commit.

kaptainkory

Yeah, I just checked the latest CVS and validation is still broken.  In themes.inc.php, editting line 857 as I suggested in my original post fixes the problem.

Thanks.

Joachim Müller

you were right, the fix has not been committed. Re-applied it and committed.