Spaces in filenames issue

[Aditya Mooley]

Why sorry Dennis? I am rather thankful to you that you are testing the code thoroghly.
I will try to fix this as soon as possible.

[Aditya Mooley]

Wasn't actually a bug in the code, but this was causing due to the extra security we give to variables from GET, POST.
Added a fix for this and committed to CVS.

[artistsinhawaii]

Aditya,

Downloaded all files and tested again

1) tested renaming illegal characters during file batch add process
           test upload name                        converted name.
        Copy of Pan_001.jpg    => Copy_of_Pan_001.jpg     (success)
        Copy of Pan_001.jpg    => Copy_of_Pan_001~01.jpg  (success)
     1 2&3;4'Copy of Pan_001.jpg  => 1_2_3;4_Copy_of_Pan_001.jpg    (success ? ";")
 
2) tested file renaming under edit picture properties.

original name                                  typed in name                      result
Copy_of_Pan_001.jpg > 1 Copy_of_Pan_001.jpg             > 1_Copy_of_Pan_001.jpg
Copy_of_Pan_001.jpg > 1 2&3;4'5 Copy_of_Pan_001.jpg  > 1_2_3;4_5_Copy_of_Pan_001.jpg

       Results are succesful ..for expected forbidden characters as long as ";"(semi-colons)   "," (commas) and "." (periods) are acceptable characters in filenames.  If ";"(semi-colons)   "," (commas) and "." (periods) are not acceptable then these need to be addressed.

Otherwise.  It all looks good.  All other forbidden characters were converted to spaces, or returned an error message if a duplicate filename existed when illegal character was converted to a space.

Great job!

Dennis

[Aditya Mooley]

"." (periods) cannot be a forbidden character as it serves as the extension for the filename.
I tested ";"(semi-colons) and "," (commas) and it worked for me as always 

[Joachim Müller]

Good work, all of you (both devs and tester)! Thanks. Marking as "fixed".