keyword list and firefox

[tvidal99]

Hi,

firstly I want to thanks you very much all the dev team ! very nice application !

Well, because i'm using firefox and not IE I find a problem with firefox (1.5.0.1) : when I upload file and click on the "Insert from list" I've got the list of my keywords. Great. But when I click on a keyword it doesn't appear in the text field !
I think it's a javascript problem ?? but I'm not a programmeur, so I can't found a solution....

Someone can help me ?

Many thnaks,

Thomas

[Roderic]

Hi there,

same with me, the keywords just don't get transferred to the main input window in FF 1.5.0.1.
JS is enabled, as well as all options in the "Advanced JavaScript Settings" menu.

Rod

[Paver]

Bug confirmed in 1.4.8.

Here's the fix.  In upload.php, in function text_box_input, replace this line:

Code Select Expand

<input type="text" style="width: 100%" name="$name" maxlength="$max_length" value="$default" class="textinput" />
with this line:

Code Select Expand

<input type="text" style="width: 100%" name="$name" maxlength="$max_length" value="$default" class="textinput" id="$name" />

So you added an id tag to the text input box, so the popup window can reference it correctly in Firefox.

I would think getElementById would require an id tag, but in IE, according to this page:

IE works correctly on elements that CAN'T have a name attribute. It works incorrectly, however, on elements that can.

So you need to have a name tag for IE (for elements that can have a name tag), and you need to have an id tag for Firefox and for IE when you have an element that doesn't have a name tag.

Phew!

Committed to 'devel' branch.  I'm skittish about adding to 'stable' branch due to a bug I added to 1.4.7.  So please make the change manually to 1.4.x if you want this to work in Firefox.

[Sami]

if you have same string for name tag and id tag , it will work without problem for both (IE ,FF)

[Paver]

Committed to stable branch.  Will be in next version (1.4.9).

[rainbowz]

Bug confirmed in 1.4.8.

Here's the fix.  In upload.php, in function text_box_input, replace this line:
...

Woot!!

This hack is also required for Safari and a few other Mac browsers . And it works perfectly, too.

Thanks tons! Now my keywords list is actually useful!