[Solved]: Other members photos appearing in personal album

[khoking]

I have members complaining that photos that don't belong to them are showing up in their members gallery.

You can see the example here:

http://pentaxworld.com/gallery/thumbnails.php?album=272

The above album is belonging to a member called smc

You can see three colour photos there, which belongs to a member called calsan. If you clicked on the colour photo, it will go to calson's album.

Why do calson's photos appearing in smc album? This is supposed to be a personal member album, other members' photos shouldn't appear there.

How to correct this?

Thanks.

[Nibbler]

Apparently the album 'People in Rome' has an album keyword of 'Street' set. Any pictures with the keyword 'Street' will be displayed in the album. If you don't want this then don't set album keywords.

Update your gallery.

[khoking]

Hi Nibbler,

Thank you very much for the fast reply and solution!

Is it possible for me to disable album keyword in the gallery? Most members will not know that the keyword is the problem that caused the mixed photos, so I might as well just disable that feature so that no members can key in any keyword in their albums.

[Joachim Müller]

Edit modifyalb, find

Code Select Expand

function form_input($text, $name)
{
    global $ALBUM_DATA;

    $value = $ALBUM_DATA[$name];

    echo <<<EOT
        <tr>
            <td width="40%" class="tableb">
                        $text
        </td>
        <td width="60%" class="tableb" valign="top">
                <input type="text" style="width: 100%" name="$name" value="$value" class="textinput" />
                </td>
        </tr>

EOT;
}and replaced with

Code Select Expand

function form_input($text, $name)
{
    global $ALBUM_DATA;

    $value = $ALBUM_DATA[$name];
   
    if ($name=='alb_password' && !GALLERY_ADMIN_MODE) {

    echo <<<EOT
        <tr>
            <td width="40%" class="tableb">
                        $text
        </td>
        <td width="60%" class="tableb" valign="top">
                <input type="hidden" style="width: 100%" name="$name" value="$value" class="textinput" />
                </td>
        </tr>

EOT;
} else {
    echo <<<EOT
        <tr>
            <td width="40%" class="tableb">
                        $text
        </td>
        <td width="60%" class="tableb" valign="top">
                <input type="text" style="width: 100%" name="$name" value="$value" class="textinput" />
                </td>
        </tr>

EOT;
}
}(coded without testing out of the back of my head, please post if this worked for you). It should hide the album keyword field for non-admins.

[khoking]

Got an error:

Parse error: syntax error, unexpected $end in /home/pentaxkk/public_html/gallery/modifyalb.php on line 623

[Joachim Müller]

Sorry, the stuff I posted above contained a flaw. Replace with

Code Select Expand

function form_input($text, $name)
{
    global $ALBUM_DATA;

    $value = $ALBUM_DATA[$name];
   
    if ($name=='alb_password' && !GALLERY_ADMIN_MODE) {

    echo <<< EOT
        <tr>
            <td width="40%" class="tableb">
                        $text
        </td>
        <td width="60%" class="tableb" valign="top">
                <input type="hidden" style="width: 100%" name="$name" value="$value" class="textinput" />
                </td>
        </tr>

EOT;
} else {
echo <<< EOT

        <tr>
            <td width="40%" class="tableb">
                        $text
        </td>
        <td width="60%" class="tableb" valign="top">
                <input type="hidden" style="width: 100%" name="$name" value="$value" class="textinput" />
                </td>
        </tr>

EOT;

}
}
instead of the stuff I posted originally.

[khoking]

Hi Joachim Müller,

Working fine now.

Thanks! I love Coppermine! 

[Joachim Müller]

I have added this as admin-settable option to cpg1.5.x 

[daverj]

OK, I'm confused.

I read through the code you posted in the second version (reply #5) and it looks to me like the HTML being generated when the "IF" statement is true is exactly the same HTML being generated when it is false. Both versions are creating a hidden form field.

If this is true, why have the IF statement at all?

[Joachim Müller]

You're right, the second form field should not be hidden, but a plain text field.