coppermine-gallery.com/forum

Support => Older/other versions => cpg1.3.x Support => Topic started by: blup1980 on November 01, 2004, 01:21:32 PM

Title: BUG Coppermine 1.3.2 in french.php and french-utf-8.php language files.
Post by: blup1980 on November 01, 2004, 01:21:32 PM
Hello

please add :

  'ISO'=>'ISO',

at line 617
this line miss into lang/french.php and in lang/french-utf-8.php, but not in lang/english.php

thanks

blup
Title: Re: BUG Coppermine 1.3.2 in french.php and french-utf-8.php language files.
Post by: Casper on November 01, 2004, 01:39:29 PM
It seems tobe missing from many language files, making me think it was added to the english.php after it was sent to the translators prior to the release of 1.3.0.

I have updated the French files in the cvs.

Thank you for your report.

Note to other devs, I will add this to all stable language files (but it will say 'ISO' regardless of actual translation)
Title: Re: BUG Coppermine 1.3.2 in french.php and french-utf-8.php language files.
Post by: Joachim Müller on November 01, 2004, 03:34:54 PM
uh-oh. Be extra carefull when editing the language files... :o
I would have fixed it the other way round: if no translation is available, don't show the iso line (as it is visible only in the picinfo section anyway).
I guess it has been added to the the english language file after the feature freeze, so let's shake the naughty finger at the dev who did ;), but leave things as they are (after all it's only as cosmetical issue, the word "iso" will be missing from the small print of a page - I'd rather have this in the "known issues" section of the cpg1.3.2 docs).

Joachim
Title: Re: BUG Coppermine 1.3.2 in french.php and french-utf-8.php language files.
Post by: Casper on November 01, 2004, 06:31:20 PM
ok, I see the logic in what you say.  Luckily I had only done and committed a few, before I had to stop.  Do you want me to roll these back, or leave them now.
Title: Re: BUG Coppermine 1.3.2 in french.php and french-utf-8.php language files.
Post by: Joachim Müller on November 01, 2004, 09:20:44 PM
If you're sure your fixes haven't broken anything I suggest you don't roll back; after all it's up to you if you continue fixing. I just wanted to point out that fixing language files can be tricky, as there might be issues that are not visible in the first place - I have broken language files in the past by "fixing" them, as encoding can cause "strange" issues.

Joachim
Title: Re: BUG Coppermine 1.3.2 in french.php and french-utf-8.php language files.
Post by: Casper on November 02, 2004, 12:05:39 PM
I've rolled back the 3 languages I could not be sure about (arabic and the 2 Chinese), and added this issue into the docs 'Known Issues', stable version only.