coppermine-gallery.com/forum

This mod is based on the 'Permanent Watermark with GD2 mod (http://forum.coppermine-gallery.net/index.php?topic=7160.0)'.
However I've rewritten the entire thing cause I didn't like the drawbacks of original 'Permanent Watermark with GD2 mod'
That mod did image resize -> save -> image resize -> save -> watermark -> save
with each step losing image quality... and an unnecesary load on the box

so that's fixed


hacks of the mod to be found in this thread:
- admin can disable watermarking whilst upload (checkbox added to upload form)
- possibility to assign different watermarks to certain users.
- better admin tool to add/ remove/ update watermarks to thumbs/ normal/ full images

added
a) an undo function. If you want to get rid of your watermarks or apply new ones. No problem. You can do that without any loss in image quality or having 2,3,4 watermarks on the image
b) watermarks can be transparent (so you can see the original image through it)
c) supports imagemagick and GD2
d) watermark can be in the center now as well
modified
in config Watermark Image on upload has been changed to Watermark Image
-> it's global now. So in Admin Tools just use 'Update thumbs and/or resized photos' to apply or remove watermarks
added a new function in Admin Tools as well if you want to delete the backup images... however then you won't be able to undo watermarks. If no watermarks are actually applied.. no problem. Go ahead and delete them. If you later create watermarks it auto creates backup images.

If you upload pictures and watermarking is disabled then no backup images get created. Only if you enable watermarking. So it doesn't waste a lot of HD

The advantage of watermarking is that full sized images get compressed. So if you upload a 2000x1000 digicam picture it may have 1.5+mb. When watermarking it get's compressed down to ~300k (depending on image quality you've set) saving you a lot of bw.

The settings in Coppermine config:
Watermark Image - Yes/No
Where to place the watermark - select a spot where your watermark should appeare
Which files to watermark - normal sized, full sized or both
Which file to use for watermark - enter full path to your watermark image
note:
GD2 needs a png (24)
Imagemagick -> jpg, gif, png with the last two you can have a transparent background
So just create in PS a Text in a second layer, delete to bg layer and save as gif or png transparent. If you use png take 24bit otherwise you'll have funny results (with GD2)

Transparency 0-100 for entire image - makes the entire watermark transparent to the bg (100 for no transparency)
Set color transparent x,y (GD2 only) - if you want to enable this uncomment the following line in picmgmnt.inc.php

//imagecolortransparent($logoImage, imagecolorat($logoImage, $CONFIG['watermark_transparency_featherx'], $CONFIG['watermark_transparency_feathery']));

what it does... if you haven't created a png with a transparent background but a white one you can select the color white (you need to know the coordinates where white appeares on the watermark, usually 1,1 fits) and GD renders white fully transparent

If it works for you as it's doing for me... or if you have problems... --> feedback appreciated

If you're using GD2 with PHP5... and your watermark doesn't look very pretty have a look here http://forum.coppermine-gallery.net/index.php?topic=16286.msg98094#msg98094

life demo (online when I'm working, register without email confirmation) http://stramm.mine.nu

downloadable already edited files http://forum.coppermine-gallery.net/index.php?topic=21469.0

so let's start

first the necessary SQL
insert into cpg_config (name, value) values ('enable_watermark', '1');
insert into cpg_config (name, value) values ('where_put_watermark', 'bottomright');
insert into cpg_config (name, value) values ('watermark_file', '/your/full/path/to/logo.png');
insert into cpg_config (name, value) values ('which_files_to_watermark', 'both');
insert into cpg_config (name, value) values ('orig_pfx', 'orig_');
insert into cpg_config (name, value) values ('watermark_transparency', '0');
insert into cpg_config (name, value) values ('watermark_transparency_featherx', '0');
insert into cpg_config (name, value) values ('watermark_transparency_feathery', '0');


now open lang/english.php
find
$lang_config_php
and add

 'wm_bottomright' => 'Bottom right',
 'wm_bottomleft' => 'Bottom left',
 'wm_topleft' => 'Up left',
 'wm_topright' => 'Up Right',
 'wm_center' => 'Center',
 'wm_both' => 'Both',
 'wm_original' => 'Original',
 'wm_resized' => 'Resized',


after
array('Display notices in debug mode', 'debug_notice', 1), //cpg1.3.0
add

'Image watermarking',
array('Watermark Image', 'enable_watermark', 1),
array('Where to place the watermark', 'where_put_watermark', 11),
array('Which files to watermark', 'which_files_to_watermark', 12),
array('Which file to use for watermark', 'watermark_file', 0),
array('Transparency 0-100 for entire image', 'watermark_transparency', 0),
array('Set color transparent x (GD2 only)', 'watermark_transparency_featherx', 0),
array('Set color transparent y (GD2 only)', 'watermark_transparency_feathery', 0),



after
'delete_orphans' => 'Delete orphaned comments (works on all albums)',   
add

 'update_full' => 'Both normal and full sized (if a orig copy is available)',
 'delete_back' => 'Delete original image backup (if you do that you can not undo watermarking)',

in
$lang_delete_php
add
 'orig_pic' => 'original image',



now we change config.php
above
function create_form(&$data)




function form_watermark($text, $name)
{
   global $CONFIG, $lang_config_php;

   $value = $CONFIG[$name];
   $southeast_selected = ($value == 'southeast') ? 'selected' : '';
   $southwest_selected = ($value == 'southwest') ? 'selected' : '';
   $northwest_selected = ($value == 'northwest') ? 'selected' : '';
   $northeast_selected = ($value == 'northeast') ? 'selected' : '';
   $center_selected = ($value == 'center') ? 'selected' : '';

   echo <<<EOT
       <tr>
           <td class="tableb">
                       $text
       </td>
       <td class="tableb" valign="top">
                       <select name="$name" class="listbox">
                               <option value="southeast" $southeast_selected>{$lang_config_php['wm_bottomright']}</option>
                               <option value="southwest" $southwest_selected>{$lang_config_php['wm_bottomleft']}</option>
                               <option value="northwest" $northwest_selected>{$lang_config_php['wm_topleft']}</option>
                               <option value="northeast" $northeast_selected>{$lang_config_php['wm_topright']}</option>
                               <option value="center" $center_selected>{$lang_config_php['wm_center']}</option>
                       </select>
               </td>
       </tr>

EOT;
}
// Added for allowing user to select which files to watermark...
function form_watermark2($text, $name)
{
   global $CONFIG, $lang_config_php;

   $value = $CONFIG[$name];
   $both_selected = ($value == 'both') ? 'selected' : '';
   $original_selected = ($value == 'original') ? 'selected' : '';
   $resized_selected = ($value == 'resized') ? 'selected' : '';

   echo <<<EOT
       <tr>
           <td class="tableb">
                       $text
       </td>
       <td class="tableb" valign="top">
                       <select name="$name" class="listbox">
                               <option value="both" $both_selected>{$lang_config_php['wm_both']}</option>
                               <option value="original" $original_selected>{$lang_config_php['wm_original']}</option>
                               <option value="resized" $resized_selected>{$lang_config_php['wm_resized']}</option>
                       </select>
               </td>
       </tr>

EOT;
}


Find this:

               case 10 :
                   form_number_dropdown($element[0], $element[1]);
                   break;

Few lines below is
Code:
die('Invalid action');
Now we need to paste this code in between

              //Watermark place
              case 11 :
                  form_watermark($element[0], $element[1]);
                                      break;
              //Which filest to watermark
              case 12 :
                  form_watermark2($element[0], $element[1]);
                                      break;
              case 13 :
                  // do nothing
                  break;


open util.php   

after        
' . $lang_util_php['update_what'] . ' (2):<br />

add below some similar lines
<input type="radio" name="updatetype" value="3" id="full" class="nobg" /><label for="full" accesskey="a" class="labelradio">' . $lang_util_php['update_full'] . '</label><br />

a few lines below
find
   starttable('100%', '<input type="radio" name="action" value="delnorm" id="delnorm" class="nobg" /><label for="delnorm" accesskey="e" class="labelradio">' . $lang_util_php['delete_original'] . '</label> (1)');
   endtable();
   print '<br />';

and below add

   starttable('100%', '<input type="radio" name="action" value="delback" id="delback" class="nobg" /><label for="delback" accesskey="e" class="labelradio">' . $lang_util_php['delete_back'] . '</label> (1)');
   endtable();
   print '<br />';


find    deleteorig();
and after add



   echo '<br /><a href="' . $phpself . '">' . $lang_util_php['back'] . '</a>';
} else if ($action == 'delback') {
   print '<a href="' . $phpself . '">' . $lang_util_php['back'] . '</a><br />';
   print '<h2>' . $lang_util_php['replace_wait'] . '</h2>';

   deletbackup_img();
   

find function deleteorphans() and above   
   

function deletbackup_img()
{
   global $picturetbl, $CONFIG, $lang_util_php;
   $albumid = $_POST['albumid'];

   $query = "SELECT * FROM $picturetbl WHERE aid = '$albumid'";
   $result = MYSQL_QUERY($query);
   $num = mysql_numrows($result);

   $i = 0;
   while ($i < $num) {
       $pid = mysql_result($result, $i, "pid");
       $back = $CONFIG['fullpath'] . mysql_result($result, $i, "filepath") . $CONFIG['orig_pfx'] . mysql_result($result, $i, "filename");

       if (file_exists($back)) {
if(unlink($back)){
               printf($lang_util_php['main_success'], $back);
               print '!<br>';
}
           } else {
               printf($lang_util_php['error_rename'], $back);
           }
       ++$i;
   }
}


replace the function updatethumbs() with (you need to delete the entire function... not only the name)

function updatethumbs()
{
set_time_limit(3600);
    global $picturetbl, $CONFIG, $lang_util_php;
    $phpself = $_SERVER['PHP_SELF'];
    $albumid = $_POST['albumid'];
    $updatetype = $_POST['updatetype'];
    $numpics = $_POST['numpics'];
    $startpic = 0;
    $startpic = $_POST['startpic'];

    $query = "SELECT * FROM $picturetbl WHERE aid = '$albumid'";
    $result = MYSQL_QUERY($query);
    $totalpics = mysql_numrows($result);
$watermark="";

    if ($startpic == 0) {
        // 0 - numpics
        $num = $totalpics;
        // Over picture limit
        if ($totalpics > $numpics) $num = $startpic + $numpics;
    } else {
        // startpic - numpics
        $num = $startpic + $numpics;
        if ($num > $totalpics) $num = $totalpics;
    }

    $i = $startpic;
    while ($i < $num) {
$imagepath=mysql_result($result, $i, "filepath");
$imagefilename=mysql_result($result, $i, "filename");
$orig=$CONFIG['fullpath'] . $imagepath . $CONFIG['orig_pfx'] . $imagefilename;
        $image = $CONFIG['fullpath'] . $imagepath . $imagefilename;
$work_image = $image;
$orig_true='false';
if (file_exists($orig)) {
$work_image=$orig;
$orig_true='true';
}
else
$work_image=$image;
        if ($updatetype == 0 || $updatetype == 2) {
            $thumb = $CONFIG['fullpath'] . mysql_result($result, $i, "filepath") . $CONFIG['thumb_pfx'] . mysql_result($result, $i, "filename");

            if (resize_image($work_image, $thumb, $CONFIG['thumb_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "false")) {
                print $thumb .' '. $lang_util_php['updated_succesfully'] . '!<br />';
                my_flush();
            } else {
                print $lang_util_php['error_create'] . ':$thumb<br />';
                my_flush();
            }
        }

        if ($updatetype == 1 || $updatetype == 2 || $updatetype == 3)
{
            $normal = $CONFIG['fullpath'] . mysql_result($result, $i, "filepath") . $CONFIG['normal_pfx'] . mysql_result($result, $i, "filename");
            if ($CONFIG['enable_watermark'] == '1' && $CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'resized')
{$watermark="true";}
else
{$watermark="false";}
            $imagesize = getimagesize($work_image);
            if (max($imagesize[0], $imagesize[1]) > $CONFIG['picture_width'] && $CONFIG['make_intermediate'])
{
                if (resize_image($work_image, $normal, $CONFIG['picture_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], $watermark))
{
                    print $normal . $lang_util_php['updated_succesfully'] . '!<br />';
                    my_flush();
}
                else
{
                    print $lang_util_php['error_create'] . ':$normal<br />';
                    my_flush();
}
}
}
       
        if ($updatetype == 3)
{
if ($orig_true == 'false')
{
if (copy($image, $orig))
{        
if ($CONFIG['enable_watermark'] == '1' && $CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'original')
{
if (resize_image($orig, $image, $imagesize[0], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "true"))
{
             print $image . $lang_util_php['updated_succesfully'] . '!<br />';
             my_flush();
}
}
}
}
else
{
if ($CONFIG['enable_watermark'] == '1' && $CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'original')
{
        $imagesize = getimagesize($orig);
if (resize_image($orig, $image, $imagesize[0], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "true"))
{
             print $image . $lang_util_php['updated_succesfully'] . '!<br />';
             my_flush();
}
}
else
{
if (copy($orig, $image))
{
                    print $orig . $lang_util_php['updated_succesfully'] . '!<br />';
                    my_flush();
}
}
}
}

        ++$i;
    }
    $startpic = $i;

    if ($startpic < $totalpics) {

        ?>
            <form action=<?php echo $phpself;
        ?> method="post">
                    <input type="hidden" name="action" value="continuethumbs" />
                    <input type="hidden" name="numpics" value="<?php echo $numpics?>" />
                    <input type="hidden" name="startpic" value="<?php echo $startpic?>" />
                    <input type="hidden" name="updatetype" value="<?php echo $updatetype?>" />
            <input type="hidden" name="albumid" value="<?php echo $albumid?>" />
            <input type="submit" value="<?php print $lang_util_php['continue'];
        ?>" class="submit" /></form>
                    <?php
    }
}




now delete.php

find a block similar to the one below and replace (just colspan has been adjusted)
   // Picture

   case 'picture':
       if (!(GALLERY_ADMIN_MODE || USER_ADMIN_MODE)) cpg_die(ERROR, $lang_errors['access_denied'], __FILE__, __LINE__);

       $pid = (int)$HTTP_GET_VARS['id'];

       pageheader($lang_delete_php['del_pic']);
       starttable("100%", $lang_delete_php['del_pic'], 7);
       output_table_header();
       $aid = delete_picture($pid);
       output_caption();
       echo "<tr><td colspan=\"7\" class=\"tablef\" align=\"center\">\n";
       echo "<div class=\"admin_menu_thumb\"><a href=\"thumbnails.php?album=$aid\"  class=\"adm_menu\">$lang_continue</a></div>\n";
       echo "</td></tr>\n";
       endtable();
       pagefooter();
       ob_end_flush();
       break;



do the same with this block
<tr>
<td class="tableh2"><b>Picture</b></td>
<td class="tableh2" align="center"><b>F</b></td>
<td class="tableh2" align="center"><b>N</b></td>
<td class="tableh2" align="center"><b>O</b></td>
<td class="tableh2" align="center"><b>T</b></td>
<td class="tableh2" align="center"><b>C</b></td>
<td class="tableh2" align="center"><b>D</b></td>
</tr>
<?php
}

function output_caption()
{
    global $lang_delete_php
    ?>
<tr><td colspan="7" class="tableb">&nbsp;</td></tr>
<tr><td colspan="7" class="tableh2"><b><?php echo $lang_delete_php['caption'] ?></b></tr>
<tr><td colspan="7" class="tableb">
<table cellpadding="1" cellspacing="0">
<tr><td><b>F</b></td><td>:</td><td><?php echo $lang_delete_php['fs_pic'] ?></td><td width="20">&nbsp;</td><td><img src="images/green.gif" border="0" width="12" height="12" align="absmiddle"></td><td>:</td><td><?php echo $lang_delete_php['del_success'] ?></td></tr>
<tr><td><b>N</b></td><td>:</td><td><?php echo $lang_delete_php['ns_pic'] ?></td><td width="20">&nbsp</td><td><img src="images/red.gif" border="0" width="12" height="12" align="absmiddle"></td><td>:</td><td><?php echo $lang_delete_php['err_del'] ?></td></tr>
<tr><td><b>O</b></td><td>:</td><td><?php echo $lang_delete_php['orig_pic'] ?></td></tr>
<tr><td><b>T</b></td><td>:</td><td><?php echo $lang_delete_php['thumb_pic'] ?></td></tr>
<tr><td><b>C</b></td><td>:</td><td><?php echo $lang_delete_php['comment'] ?></td></tr>
<tr><td><b>D</b></td><td>:</td><td><?php echo $lang_delete_php['im_in_alb'] ?></td></tr>
</table>
</td>
</tr>



in function delete_picture($pid) find line similar to the following and replace
     $files = array($dir . $file, $dir . $CONFIG['normal_pfx'] . $file, $dir . $CONFIG['thumb_pfx'] . $file, $dir . $CONFIG['orig_pfx'] . $file);

the rest is easy
rename or delete the file include/picmgmt.inc.php

and create a file include/picmgmt.inc.php that contains


<?php
// ------------------------------------------------------------------------- //
// Coppermine Photo Gallery 1.3.2                                            //
// ------------------------------------------------------------------------- //
// Copyright (C) 2002-2004 Gregory DEMAR                                     //
// http://www.chezgreg.net/coppermine/                                       //
// ------------------------------------------------------------------------- //
// Updated by the Coppermine Dev Team                                        //
// (http://coppermine.sf.net/team/)                                          //
// see /docs/credits.html for details                                        //
// ------------------------------------------------------------------------- //
// This program is free software; you can redistribute it and/or modify      //
// it under the terms of the GNU General Public License as published by      //
// the Free Software Foundation; either version 2 of the License, or         //
// (at your option) any later version.                                       //
// ------------------------------------------------------------------------- //
// CVS version: $Id: picmgmt.inc.php,v 1.8 2004/07/27 13:58:04 oddeveloper Exp $
// ------------------------------------------------------------------------- //

// Add a picture to an album
function add_picture($aid, $filepath, $filename, $title = '', $caption = '', $keywords = '', $user1 = '', $user2 = '', $user3 = '', $user4 = '', $category = 0, $raw_ip = '', $hdr_ip = '',$iwidth=0,$iheight=0)
{
    global $CONFIG, $ERROR, $USER_DATA, $PIC_NEED_APPROVAL;
    global $lang_errors;

    $image = $CONFIG['fullpath'] . $filepath . $filename;
    $normal = $CONFIG['fullpath'] . $filepath . $CONFIG['normal_pfx'] . $filename;
    $thumb = $CONFIG['fullpath'] . $filepath . $CONFIG['thumb_pfx'] . $filename;
    $orig = $CONFIG['fullpath'] . $filepath . $CONFIG['orig_pfx'] . $filename;
$work_image = $image;
    if (!is_known_filetype($image)) {
        return false;
    } elseif (is_image($filename)) {
if (!file_exists($orig) && $CONFIG['enable_watermark'] == '1' && ($CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'original'))  {
// if copy of full_sized doesn't exist and if watermark enabled and if fullsized pic watermark=true -> then we need a backup
if (!copy($image, $orig))
                return false;
else
$work_image = $orig;
}
        if (!file_exists($thumb)) {
            if (!resize_image($work_image, $thumb, $CONFIG['thumb_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "false"))
                return false;
        }
        $imagesize = getimagesize($work_image);
        if (max($imagesize[0], $imagesize[1]) > $CONFIG['picture_width'] && $CONFIG['make_intermediate'] && !file_exists($normal)) {
            if ($CONFIG['enable_watermark'] == '1' && $CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'resized'){
if (!resize_image($work_image, $normal, $CONFIG['picture_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "true"))
                 return false;
}
else {
if (!resize_image($work_image, $normal, $CONFIG['picture_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "false"))
            return false;
}
}
/*else {
if (!resize_image($work_image, $normal, $CONFIG['picture_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "false"))
                return false;

}*/
        if ($CONFIG['enable_watermark'] == '1' && $CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'original'){
if (!resize_image($work_image, $image, $imagesize[0], $CONFIG['thumb_method'], 'orig', 'true'))
                 return false;
}
    } else {
        $imagesize[0] = $iwidth;
        $imagesize[1] = $iheight;
    }


    $image_filesize = filesize($image);
    $total_filesize = is_image($filename) ? ($image_filesize + (file_exists($normal) ? filesize($normal) : 0) + filesize($thumb)) : ($image_filesize);


    // Test if disk quota exceeded
    if (!GALLERY_ADMIN_MODE && $USER_DATA['group_quota']) {
        $result = db_query("SELECT sum(total_filesize) FROM {$CONFIG['TABLE_PICTURES']}, {$CONFIG['TABLE_ALBUMS']} WHERE  {$CONFIG['TABLE_PICTURES']}.aid = {$CONFIG['TABLE_ALBUMS']}.aid AND category = '" . (FIRST_USER_CAT + USER_ID) . "'");
        $record = mysql_fetch_array($result);
        $total_space_used = $record[0];
        mysql_free_result($result);

        if ((($total_space_used + $total_filesize)>>10) > $USER_DATA['group_quota'] ) {
            @unlink($image);
            if (is_image($image)) {
                @unlink($normal);
                @unlink($thumb);
            }
            $msg = strtr($lang_errors['quota_exceeded'], array('[quota]' => ($USER_DATA['group_quota']),
                '[space]' => ($total_space_used >> 10)));
            cpg_die(ERROR, $msg, __FILE__, __LINE__);
        }
    }
    // Test if picture requires approval
    if (GALLERY_ADMIN_MODE) {
        $approved = 'YES';
    } elseif (!$USER_DATA['priv_upl_need_approval'] && $category == FIRST_USER_CAT + USER_ID) {
        $approved = 'YES';
    } elseif (!$USER_DATA['pub_upl_need_approval']) {
        $approved = 'YES';
    } else {
        $approved = 'NO';
    }
    $PIC_NEED_APPROVAL = ($approved == 'NO');
    // User ID is now recorded when in admin mode (casper)
    $user_id = USER_ID;
    $username= USER_NAME;
    $query = "INSERT INTO {$CONFIG['TABLE_PICTURES']} (pid, aid, filepath, filename, filesize, total_filesize, pwidth, pheight, ctime, owner_id, owner_name, title, caption, keywords, approved, user1, user2, user3, user4, pic_raw_ip, pic_hdr_ip) VALUES ('', '$aid', '" . addslashes($filepath) . "', '" . addslashes($filename) . "', '$image_filesize', '$total_filesize', '{$imagesize[0]}', '{$imagesize[1]}', '" . time() . "', '$user_id', '$username','$title', '$caption', '$keywords', '$approved', '$user1', '$user2', '$user3', '$user4', '$raw_ip', '$hdr_ip')";
    $result = db_query($query);

    return $result;
}

define("GIS_GIF", 1);
define("GIS_JPG", 2);
define("GIS_PNG", 3);

// Add 'edit' directory if it doesn't exist
// Set access to read+write only
if (!is_dir($CONFIG['fullpath'].'edit')) {
    $cpg_umask = umask(0);
    @mkdir($CONFIG['fullpath'].'edit',0666);
    umask($cpg_umask);
    unset($cpg_umask);
}

/**
* resize_image()
*
* Create a file containing a resized image
*
* @param  $src_file the source file
* @param  $dest_file the destination file
* @param  $new_size the size of the square within which the new image must fit
* @param  $method the method used for image resizing
* @return 'true' in case of success
*/
function resize_image($src_file, $dest_file, $new_size, $method, $thumb_use, $watermark="false")
{
    global $CONFIG, $ERROR;
    global $lang_errors;

    $imginfo = getimagesize($src_file);
    if ($imginfo == null)
        return false;
        // GD can only handle JPG & PNG images
    if ($imginfo[2] != GIS_JPG && $imginfo[2] != GIS_PNG && ($method == 'gd1' || $method == 'gd2')) {
        $ERROR = $lang_errors['gd_file_type_err'];
        return false;
    }
    // height/width
    $srcWidth = $imginfo[0];
    $srcHeight = $imginfo[1];
    if ($thumb_use == 'ht') {
        $ratio = $srcHeight / $new_size;
    } elseif ($thumb_use == 'wd') {
        $ratio = $srcWidth / $new_size;
    } else {
        $ratio = max($srcWidth, $srcHeight) / $new_size;
    }
    $ratio = max($ratio, 1.0);
if ($thumb_use == 'orig') $ratio=1.0;
    $destWidth = (int)($srcWidth / $ratio);
    $destHeight = (int)($srcHeight / $ratio);
    // Method for thumbnails creation
    switch ($method) {
        case "im" :
            if (preg_match("#[A-Z]:|\\\\#Ai", __FILE__)) {
                // get the basedir, remove '/include'
                $cur_dir = substr(dirname(__FILE__), 0, -8);
                $src_file = '"' . $cur_dir . '\\' . strtr($src_file, '/', '\\') . '"';
                $im_dest_file = str_replace('%', '%%', ('"' . $cur_dir . '\\' . strtr($dest_file, '/', '\\') . '"'));
            } else {
                $src_file = escapeshellarg($src_file);
                $im_dest_file = str_replace('%', '%%', escapeshellarg($dest_file));
            }

            $output = array();
$anno_txt="";
$annotate="";

            /*
             * Hack for working with ImageMagick on WIndows even if IM is installed in C:\Program Files.
             * By Aditya Mooley <aditya@sanisoft.com>
             */

                $cmd = "{$CONFIG['impath']}convert -quality {$CONFIG['jpeg_qual']} {$CONFIG['im_options']} -geometry {$destWidth}x{$destHeight} $annotate $src_file $im_dest_file";
exec ($cmd, $output, $retval);
if ($watermark == "true"){
$cmd = "{$CONFIG['impath']}composite -dissolve {$CONFIG['watermark_transparency']} -gravity {$CONFIG['where_put_watermark']} {$CONFIG['watermark_file']} $im_dest_file $im_dest_file";
exec ($cmd, $output, $retval);
             }

            if ($retval) {
                $ERROR = "Error executing ImageMagick - Return value: $retval";
                if ($CONFIG['debug_mode']) {
                    // Re-execute the command with the backtit operator in order to get all outputs
                    // will not work is safe mode is enabled
                    $output = `$cmd 2>&1`;
                    $ERROR .= "<br /><br /><div align=\"left\">Cmd line : <br /><font size=\"2\">" . nl2br(htmlspecialchars($cmd)) . "</font></div>";
                    $ERROR .= "<br /><br /><div align=\"left\">The convert program said:<br /><font size=\"2\">";
                    $ERROR .= nl2br(htmlspecialchars($output));
                    $ERROR .= "</font></div>";
                }
                @unlink($dest_file);
                return false;
            }
            break;

        case "gd1" :
            if (!function_exists('imagecreatefromjpeg')) {
                cpg_die(CRITICAL_ERROR, 'PHP running on your server does not support the GD image library, check with your webhost if ImageMagick is installed', __FILE__, __LINE__);
            }
            if ($imginfo[2] == GIS_JPG)
                $src_img = imagecreatefromjpeg($src_file);
            else
                $src_img = imagecreatefrompng($src_file);
            if (!$src_img) {
                $ERROR = $lang_errors['invalid_image'];
                return false;
            }
            $dst_img = imagecreate($destWidth, $destHeight);
            imagecopyresized($dst_img, $src_img, 0, 0, 0, 0, $destWidth, (int)$destHeight, $srcWidth, $srcHeight);
            imagejpeg($dst_img, $dest_file, $CONFIG['jpeg_qual']);
            imagedestroy($src_img);
            imagedestroy($dst_img);
            break;

        case "gd2" :
            if (!function_exists('imagecreatefromjpeg')) {
                cpg_die(CRITICAL_ERROR, 'PHP running on your server does not support the GD image library, check with your webhost if ImageMagick is installed', __FILE__, __LINE__);
            }
            if (!function_exists('imagecreatetruecolor')) {
                cpg_die(CRITICAL_ERROR, 'PHP running on your server does not support GD version 2.x, please switch to GD version 1.x on the config page', __FILE__, __LINE__);
            }
            if ($imginfo[2] == GIS_JPG)
                $src_img = imagecreatefromjpeg($src_file);
            else
                $src_img = imagecreatefrompng($src_file);
            if (!$src_img) {
                $ERROR = $lang_errors['invalid_image'];
                return false;
            }
            $dst_img = imagecreatetruecolor($destWidth, $destHeight);
            imagecopyresampled($dst_img, $src_img, 0, 0, 0, 0, $destWidth, (int)$destHeight, $srcWidth, $srcHeight);
            
if ($watermark == "true"){
$logoImage = ImageCreateFromPNG($CONFIG['watermark_file']); 
    $logoW = ImageSX($logoImage); 
    $logoH = ImageSY($logoImage); 
    //where is the watermark displayed... 
    $pos = $CONFIG['where_put_watermark']; 
if ($pos == "northwest") { 
$src_x = 5;  
$src_y = 5; 
} else if ($pos == "northeast") { 
$src_x = $destWidth - ($logoW + 5); 
$src_y = 5; 
} else if ($pos == "southwest") { 
$src_x = 5; 
$src_y = $destHeight - ($logoH + 5); 
} else if ($pos == "southeast") { 
$src_x = $destWidth - ($logoW + 5); 
$src_y = $destHeight - ($logoH + 5); 
} else if ($pos == "center") { 
$src_x = ($destWidth/2) - ($logoW/2); 
$src_y = ($destHeight/2) - ($logoH/2); 
} 

// no, we don't support that in the script, overkill... just make a transparentbkg png and don't be so lazy
//imagecolortransparent($logoImage, imagecolorat($logoImage, $CONFIG['watermark_transparency_featherx'], $CONFIG['watermark_transparency_feathery']));
imagealphablending($dst_img, TRUE);
imagecolortransparent($logoImage, imagecolorat($logoImage, $CONFIG['watermark_transparency_featherx'], $CONFIG['watermark_transparency_feathery']));
ImageCopyMerge($dst_img,$logoImage,$src_x,$src_y,0,0,$logoW,$logoH,$CONFIG['watermark_transparency']); //$dst_x,$dst_y,0,0,$logoW,$logoH); 
}
imagejpeg($dst_img, $dest_file, $CONFIG['jpeg_qual']);
            imagedestroy($src_img);
            imagedestroy($dst_img);
            break;
    }
    // Set mode of uploaded picture
    chmod($dest_file, octdec($CONFIG['default_file_mode']));
    // We check that the image is valid
    $imginfo = getimagesize($dest_file);
    if ($imginfo == null) {
        $ERROR = $lang_errors['resize_failed'];
        @unlink($dest_file);
        return false;
    } else {
        return true;
    }
}
?>




That's it... have fun

bug fix: in editpics.php find
                        $files=array($dir.$file, $dir.$CONFIG['normal_pfx'].$file, $dir.$CONFIG['thumb_pfx'].$file);

replace with
                        $files=array($dir.$file, $dir.$CONFIG['normal_pfx'].$file, $dir.$CONFIG['thumb_pfx'].$file, $dir.$CONFIG['orig_pfx'].$file);


in searchnew
            if (strncmp($file, $CONFIG['thumb_pfx'], strlen($CONFIG['thumb_pfx'])) != 0 && strncmp($file, $CONFIG['normal_pfx'], strlen($CONFIG['normal_pfx'])) != 0 && $file != 'index.html')

with
            if (strncmp($file, $CONFIG['orig_pfx'], strlen($CONFIG['orig_pfx'])) != 0 && strncmp($file, $CONFIG['thumb_pfx'], strlen($CONFIG['thumb_pfx'])) != 0 && strncmp($file, $CONFIG['normal_pfx'], strlen($CONFIG['normal_pfx'])) != 0 && $file != 'index.html')


I'm going to try it right now.

In Util.php...

ERROR creating:$thumb
ERROR creating:$normal
ERROR creating:$thumb
ERROR creating:$thumb
ERROR creating:$thumb
ERROR creating:$thumb

(w/ watermarking on)

When it's off, no problem.

Quote from: lancefiasco on April 03, 2005, 03:17:27 AM
In Util.php...

ERROR creating:$thumb
ERROR creating:$normal
ERROR creating:$thumb
ERROR creating:$thumb
ERROR creating:$thumb
ERROR creating:$thumb

(w/ watermarking on)

When it's off, no problem.

Can you upload single pictures with watermarking enabled.
Just with that info I can't tell you much... except that it usually means the system can't find the source file from where to create the files. It's a simple process. It checks if there's a copy of the uploaded full size image and if it's there it's using it, otherwise it takes the full sized image.

So open include/picmgmt.inc.php and insert
echo "Source: $src_file --- Destination: $dest_file<br>";

after
function resize_image($src_file, $dest_file, $new_size, $method, $thumb_use, $watermark)
{
   global $CONFIG, $ERROR;
   global $lang_errors;


then run it again. Now it'll tell you what file it's using as source and what file it's updating. Knowing that it shouldn't be a problem to fix it.

Oh, and I've forgotten to ask what you're using, GD2 or IM, *nix or win

Quote from: Stramm on April 03, 2005, 09:16:27 AM

Quote from: lancefiasco on April 03, 2005, 03:17:27 AM
In Util.php...

ERROR creating:$thumb
ERROR creating:$normal
ERROR creating:$thumb
ERROR creating:$thumb
ERROR creating:$thumb
ERROR creating:$thumb

(w/ watermarking on)

When it's off, no problem.

Can you upload single pictures with watermarking enabled.
Just with that info I can't tell you much... except that it usually means the system can't find the source file from where to create the files. It's a simple process. It checks if there's a copy of the uploaded full size image and if it's there it's using it, otherwise it takes the full sized image.

So open include/picmgmt.inc.php and insert

Code Select Expand

echo "Source: $src_file --- Destination: $dest_file<br>";

after

Code Select Expand

function resize_image($src_file, $dest_file, $new_size, $method, $thumb_use, $watermark)
{
    global $CONFIG, $ERROR;
    global $lang_errors;


then run it again. Now it'll tell you what file it's using as source and what file it's updating. Knowing that it shouldn't be a problem to fix it.

Oh, and I've forgotten to ask what you're using, GD2 or IM, *nix or win

ImageMagick on Linux

And, no, I cannot upload single pictures with watermarking enabled.

I'm going to try what you said, and then report back.

Warning: Missing argument 6 for resize_image() in /home/gcfiasco/public_html/include/picmgmt.inc.php on line 134
Source: ./albums/edit/mHTTP_temp_2ac88500.jpg --- Destination: ./albums/edit/preview_14f1dd66.jpg

the error you got doesn't matter at all... but you can fix it with replacing the function resize_image line with

function resize_image($src_file, $dest_file, $new_size, $method, $thumb_use, $watermark="false")

or just copy/ paste picmgmt.inc.php from above. It's fixed there

when you've added the echo line I told you what does it spit out and do the images it tells you exist?? From most interest are the images orig_something.jpg (that's when you do the batch stuff)

Source: albums/userpics/10001/orig_108.jpg --- Destination: albums/userpics/10001/thumb_108.jpg
Source: albums/userpics/10001/orig_108.jpg --- Destination: albums/userpics/10001/normal_108.jpg
Source: albums/userpics/10001/orig_108.jpg --- Destination: albums/userpics/10001/108.jpg

Is that what you're looking for?

All those files exist...still no watermark.

That all sounds pretty much OK :)
So my guess is that either the path to your watermark image is wrong or that it's a wrong format (I hope you use png... that's working perfect). But really, check the path, it has to be the absolute, full path to your watermark image

to check that add
if(!is_image($CONFIG['where_put_watermark'])) cpg_die(ERROR, "Watermark file not found or no image!!", __FILE__, __LINE__);

above (~line 180+ in picmgmt.inc.php)
$cmd = "{$CONFIG['impath']}composite -dissolve {$CONFIG['watermark_transparency']} -gravity {$CONFIG['where_put_watermark']} {$CONFIG['watermark_file']} $im_dest_file $im_dest_file";
and run the batch tool

if this is not the problem check if the composite command can be executed

"Watermark file not found or no image!!"

I have it set to "/images/watermark.png"...

I also tried "images/watermark.png" as well as "http://www.gcfiasco.com/images/watermark.png".

You might need the full absolute path. Ask your webhost for details.

lol, OK, a long story for a simple mistake...
you need the absolute server path.. what you give it is the relative path

save that as eg docroot.php
<?php
echo $_SERVER['DOCUMENT_ROOT'];
?>

upload it and run it.. it tells you the absolute path to your document root. To that add your coppermine dir and the image dir + watermark filename

eg it spits out /usr/home/Yourname/sites/yoursite.com/htdocs
then add to that path eg /coppermine/images/watermark.png

so you get teh absolute pyth to your watermark image
/usr/home/Yourname/sites/yoursite.com/htdocs/coppermine/images/watermark.png
easy, huh

Have fun

Changed to /home/gcfiasco/public_html/images/watermark.png, and it STILL gives me that same error. :(

http://www.gcfiasco.com/images/watermark.png == 403 forbidden. CHMOD it so it is readable.

Quote from: Nibbler on April 03, 2005, 09:53:28 PM
http://www.gcfiasco.com/images/watermark.png == 403 forbidden. CHMOD it so it is readable.

That's odd...I can read it.  And it's CHMODed to 755.

it'S strange.. but I have no clue how your box is setup. If it's a forbidden error you can try 777 too or you change the owner to www (usually php in in that group) and php maybe setup to not be able to read other group files (for security reasons, usually when your on a shared box).

Here I can't help you any further. That's nothing to do with the script but with server setup. You should ask your support or, as said chmod to 777 and chown to www (or in whatever group php may be)

and it now doesn't die anymore with a wrong path to watermark image error?? (in batch tool)

Quote from: Stramm on April 03, 2005, 10:21:44 PM
and it now doesn't die anymore with a wrong path to watermark image error?? (in batch tool)

Nope.

then the pic's found but can't be accessed. That's server setup issues. If you're not afraid of commandline you probably can fix it yourself. A test if it's what I think is just to upload the watermark image through coppermine... then change the watermark path to the uploaded image.. test. If it's working then your host or you should chown the watermark pic.

Quote from: Stramm on April 04, 2005, 08:56:22 AM
A test if it's what I think is just to upload the watermark image through coppermine... then change the watermark path to the uploaded image..

Also does not work.

Could an .htaccess file have anything to do with this?

nope, the script is accessing the file directly, not using the webserver

Now that I've tested that, where should I go from here?

I'm having some major problems SSH'ing...

you could tell me exactly what you do, what error message comes up. Enable debugging...
Is it an error that coppermine gives (embedded in coppermine layout) or is it different...

where and when and what does tell you 'forbidden'

no ssh is a pity too. I'll post some code later so that you can test IM and it's composite function.

I do not get a forbidden error at all.

The only error message I experience is "No watermark..."

Notice: Undefined offset: 2 in /home/gcfiasco/public_html/upload.php on line 250

Notice: Undefined offset: 3 in /home/gcfiasco/public_html/upload.php on line 256

Notice: Undefined offset: 4 in /home/gcfiasco/public_html/upload.php on line 256

Notice: Undefined variable: file_failure_array in /home/gcfiasco/public_html/upload.php on line 1940

Notice: Undefined variable: URI_failure_array in /home/gcfiasco/public_html/upload.php on line 1941

Notice: Undefined variable: zip_failure_array in /home/gcfiasco/public_html/upload.php on line 1942

Watermark file not found or no image!!

File: /home/gcfiasco/public_html/include/picmgmt.inc.php - Line: 185

Notice: Undefined index: user1 in /home/gcfiasco/public_html/upload.php on line 2146

Notice: Undefined index: user2 in /home/gcfiasco/public_html/upload.php on line 2147

Notice: Undefined index: user3 in /home/gcfiasco/public_html/upload.php on line 2148

Notice: Undefined index: user4 in /home/gcfiasco/public_html/upload.php on line 2149

Notice: Undefined index: center in /home/gcfiasco/public_html/include/media.functions.inc.php on line 51

I will try to revert to a backed up upload.php, and then re-mod that.  I've had a feeling that I did something wrong in the coding from all along.  I should have just checked sooner.

Also, I read that watermark can be in the center, but this also warrants an error.  What do I need to set this as?

something is definitely worng.. but it's not upload php. The modded files are delete.php (so that you can delete the backup files as well), util.php (same reason, that the backup files get included when doing batch stuff), picmgmt.inc.php (here's the watermark stuff, so when you upload, that file gets called... and when a pic gets resized then it'll get a watermark applied as well) and finally the english.php file. That's all.

So if upload spits out errors... not that good

I'm just having so many problems for some reason.  Is there anyway you can send the files premoded?  Is that even allowed?

Why shouldn't it be allowed... but I've heavily modded my version. VBulletin style PM system, additional tags for the template, shoutbox, massmailer, lots of style changes, bunch of mysql additions and whatever

Yeah, then that will not work.

Maybe you can somehow simplify your directions?

your lucky day... I've just seen that I still have my test version. Only the watermark mod's applied there. PM me your email addy if you want to have it

I got your files...still doesn't work :(

Notice: Undefined index: wm_resized in /home/gcfiasco/public_html/config.php on line 411 (when I run config.php)

Notice: Undefined index: startpic in /home/gcfiasco/public_html/util.php on line 139 (when I run util.php)

...as well as the other errors I mentioned before..

these errors don't mind... check it out on your local win box. It's working smooth there I bet... I've tested on two win machines, on FreeBSD and a Redhat box. Works everywhere. As said, I guess it's some weird permission/ group stuff your host's setup for security reasons. If you still haven't asked support you should do so.

I don't even know if my ImageMagick is working correctly because I just set a Coppermine up on another account and it gave me a permission error.

I have ImageMagick enabled in the configuration, but how can I tell if I am actually using it?

if ImageMagick is configured this will spit out all supported formats

<?php
exec ("convert -list format", $return);
foreach($return as $out) { 
echo "$out<br>";
}
?>

I contacted the host, who told me that the file was owned by my user name.

I am having the same problems.....


I tried all the fixes mentioned in the previous posts and am still getting errors.

I am running cpg 1.3.2 bridged w/ phpbb 2.13 on an apache (I have shh access)

my watermark is a .png file (chmod 777) and can be found here (http://www.staticfiends.com/photos/images/watermark.png) and its path in config.php is: /home/staticp/public_html/photos/images/watermark.png

:-\\

here is the error it sends me when I attempt to upload a single photo w/ the watermark

QuoteWatermark file not found or no image!!

File: /home/staticp/public_html/photos/include/picmgmt.inc.php - Line: 188



Notice: Undefined index: user1 in /home/staticp/public_html/photos/upload.php on line 2146

Notice: Undefined index: user2 in /home/staticp/public_html/photos/upload.php on line 2147

Notice: Undefined index: user3 in /home/staticp/public_html/photos/upload.php on line 2148

Notice: Undefined index: user4 in /home/staticp/public_html/photos/upload.php on line 2149
Source: albums/userpics/10004/orig_Picture1~1.jpg --- Destination: albums/userpics/10004/thumb_Picture1~1.jpg
Source: albums/userpics/10004/orig_Picture1~1.jpg --- Destination: albums/userpics/10004/normal_Picture1~1.jpg

Notice: Undefined index: bottomright in /home/staticp/public_html/photos/include/media.functions.inc.php on line 51

line 51 in media.functions.inc.php is:

   if (!is_null($filter) && $FILE_TYPES[$filename[$EOA]]['content']==$filter)



in case you need it, here is my debug info:

USER:
------------------
Array
(
   [ID] => 4e852da6faa5c227c3908eb58b711d41
   [am] => 1
   [liv] => Array
       (
           [0] => 4
           [1] => 13
           [2] => 7
           [3] => 18
           [4] => 19
       )

   [search] => assssss
)

==========================
USER DATA:
------------------
Array
(
   [0] => 4
   [user_id] => 4
   [1] => buffalo soulJAH
   [user_name] => buffalo soulJAH
   [2] => 1
   [user_level] => 1
   [groups] => Array
       (
           [0] => 1
           [1] => 2
           [2] => 1761
           [3] => 7035
       )

   [group_quota] => 0
   [can_rate_pictures] => 1
   [can_send_ecards] => 1
   [can_post_comments] => 1
   [can_upload_pictures] => 1
   [can_create_albums] => 1
   [pub_upl_need_approval] => 0
   [priv_upl_need_approval] => 0
   [upload_form_config] => 3
   [num_file_upload] => 5
   [num_URI_upload] => 3
   [custom_user_upload] => 0
   [disk_max] => 1024
   [disk_min] => 0
   [ufc_max] => 3
   [ufc_min] => 0
   [has_admin_access] => 1
   [group_name] => Administrators
   [can_see_all_albums] => 1
   [group_id] => 1
)

==========================
Queries:
------------------
Array
(
   [0] => SELECT extension, mime, content FROM cpg132_filetypes;
   [1] => SELECT user_id, username as user_name, user_level FROM phpbb_sessions INNER JOIN phpbb_users ON session_user_id = user_id WHERE session_id='0d649a19bf69a3aed5ac368ac28ff960' AND session_user_id ='4' AND user_active='1'
   [2] => SELECT (ug.group_id + 5) as group_id FROM phpbb_user_group as ug LEFT JOIN phpbb_groups as g ON ug.group_id = g.group_id WHERE user_id = 4 AND user_pending = 0 AND group_single_user = 0
   [3] => SELECT MAX(group_quota) as disk_max, MIN(group_quota) as disk_min, MAX(can_rate_pictures) as can_rate_pictures, MAX(can_send_ecards) as can_send_ecards, MAX(upload_form_config) as ufc_max, MIN(upload_form_config) as ufc_min, MAX(custom_user_upload) as custom_user_upload, MAX(num_file_upload) as num_file_upload, MAX(num_URI_upload) as num_URI_upload, MAX(can_post_comments) as can_post_comments, MAX(can_upload_pictures) as can_upload_pictures, MAX(can_create_albums) as can_create_albums, MAX(has_admin_access) as has_admin_access, MIN(pub_upl_need_approval) as pub_upl_need_approval, MIN( priv_upl_need_approval) as  priv_upl_need_approval FROM cpg132_usergroups WHERE group_id in (1,2,1761,7035)
   [4] => SELECT group_name FROM  cpg132_usergroups WHERE group_id= 1
   [5] => DELETE FROM cpg132_banned WHERE expiry < 1113332433
   [6] => SELECT * FROM cpg132_banned WHERE ip_addr='65.40.255.161' OR ip_addr='65.40.255.161' OR user_id=4
   [7] => SELECT category FROM cpg132_albums WHERE aid='1'
)

==========================
GET :
------------------
Array
(
)

==========================
POST :
------------------
Array
(
   [album] => 1
   [title] => test
   [caption] => test
   [keywords] => test
   [control] => phase_2
   [unique_ID] => b9842480
)

==========================
VERSION INFO :
------------------
PHP version: 4.3.10 - OK
------------------
mySQL version: 4.0.22-standard
------------------
Coppermine version: 1.3.2
==========================
Module: gd
------------------
GD Support enabled
GD Version bundled (2.0.28 compatible)
GIF Read Support enabled
GIF Create Support enabled
JPG Support enabled
PNG Support enabled
WBMP Support enabled
XBM Support enabled
==========================
Module: mysql
------------------
Active Persistent Links 0
Active Links 1
Client API version 3.23.49
MYSQL_MODULE_TYPE builtin
MYSQL_SOCKET /var/tmp/mysql.sock
MYSQL_INCLUDE no value
MYSQL_LIBS no value
==========================
Module: zlib
------------------
ZLib Support enabled
Compiled Version 1.1.4
Linked Version 1.1.4
==========================
Server restrictions (safe mode)?
------------------
Directive | Local Value | Master Value
safe_mode | Off | Off
safe_mode_exec_dir | no value | no value
safe_mode_gid | Off | Off
safe_mode_include_dir | no value | no value
safe_mode_exec_dir | no value | no value
sql.safe_mode | Off | Off
disable_functions | no value | no value
file_uploads | On | On
include_path | .:/usr/lib/php:/usr/local/lib/php | .:/usr/lib/php:/usr/local/lib/php
open_basedir | no value | no value
==========================
email
------------------
Directive | Local Value | Master Value
sendmail_from | no value | no value
sendmail_path | /usr/sbin/sendmail -t -i | /usr/sbin/sendmail -t -i
SMTP | localhost | localhost
smtp_port | 25 | 25
==========================
Size and Time
------------------
Directive | Local Value | Master Value
max_execution_time | 90 | 90
max_input_time | -1 | -1
upload_max_filesize | 25M | 25M
post_max_size | 100M | 100M
==========================
Page generated in 1.19 seconds - 8 queries in 0.004 seconds - Album set :


thanks in advance  8)

Quote from: GauGau on April 14, 2005, 09:43:19 AM
search (http://forum.coppermine-gallery.net/index.php?action=search) the board for the error messages you get; they're not related to the watermarking hack. Please do not reply to this thread about the error you get, as the discussion would clutter this unrelated thread. Always make sure your install is working before applying a hack. Once you fixed those error messages and uploads are working as expected, re-apply this hack and turn to this thread if the hack itself doesn't work for you.

Joachim

sorry  :-[  it was working until I tried to get the watermark hack going....so I just figured that was the problem...thanks for your help.


the Watermark file not found or no image!! error is still there though

search (http://forum.coppermine-gallery.net/index.php?action=search) the board for the error messages you get; they're not related to the watermarking hack. Please do not reply to this thread about the error you get, as the discussion would clutter this unrelated thread. Always make sure your install is working before applying a hack. Once you fixed those error messages and uploads are working as expected, re-apply this hack and turn to this thread if the hack itself doesn't work for you.

Joachim

Quoteso let's start

first the necessary SQL
Code:
insert into cpg_config (name, value) values ('enable_watermark', '1');
insert into cpg_config (name, value) values ('where_put_watermark', 'bottomright');
insert into cpg_config (name, value) values ('watermark_file', '/your/full/path/to/logo.png');
insert into cpg_config (name, value) values ('which_files_to_watermark', 'both');
insert into cpg_config (name, value) values ('orig_pfx', 'orig_');
insert into cpg_config (name, value) values ('watermark_transparency', '0');
insert into cpg_config (name, value) values ('watermark_transparency_featherx', '0');
insert into cpg_config (name, value) values ('watermark_transparency_feathery', '0');

Okay so I guess I'm just not getting this..... I've figured out that I have to go into the /coppermine/sql folder and insert this into one of the files... but I'm not sure what one to modify (if it even matters).  I have the choice of basic, schema, and update sql files...

Anyone have an idea what one is supposed to get the code above?

Okay so I gave it a go figuring I've got a recent backup and nothing I can do but learn from this.

I updated basic.sql with the code from above and modified the rest of the files per this thread.  When I try to do a single picture upload I get these errors after placing it into an album:

Warning: imagesx(): supplied argument is not a valid Image resource in /usr/local/apache2/htdocs/Levanger/coppermine/include/picmgmt.inc.php on line 245

Warning: imagesy(): supplied argument is not a valid Image resource in /usr/local/apache2/htdocs/Levanger/coppermine/include/picmgmt.inc.php on line 246

Warning: imagecolorat(): supplied argument is not a valid Image resource in /usr/local/apache2/htdocs/Levanger/coppermine/include/picmgmt.inc.php on line 269

Warning: imagecolortransparent(): supplied argument is not a valid Image resource in /usr/local/apache2/htdocs/Levanger/coppermine/include/picmgmt.inc.php on line 269

Warning: imagecopymerge(): supplied argument is not a valid Image resource in /usr/local/apache2/htdocs/Levanger/coppermine/include/picmgmt.inc.php on line 270

In my coppermine config I'm set to
GD2
Watermark Yes
Center
Both
/images/watermark.png (I have also tried /usr/local/apache2/htdocs/Levanger/coppermine/images/watermark.png).

Any suggestions?

you can use phpMyAdmin to do the sql stuff...just make sure that you insert the code into the right db and that you customize the code to fit your site path to the watermark.

let me know if you get it to work...because I still have the same problem that I listed above  :-\\

just adding the sql stuff to one of the files in your coppermine sql folder won't work. You'll have to either use commandline or phpmyadmin to add these to your current db config

freesouljah:
Thanks for your time to post a response.  I had already looked at the thread from Burpee where he noted to do the sql with phpmyadmin or webmin.  It then made sense.  I used webmin and  I did have to modify
cpg_config
To say what fit my database table like this:
cpg132_config

I now have the watermark setup working but never ran into the upload issues you have.  May I suggest trying with a vanilla install of CPG and a clean database then start the mods over?

Stramm:
Thank you very much for the time you spent to create this version and posting your thoughts on what I had to do to get it working.  I had already got it working and had stumbled into a few other issues.

I noticed one issue right away when I got it working and that was I couldn't get the watermark to move to a different spot in the picture.  It took some looking in the files I modified per your directions and your naming system to type into the config options isn't "bottomright" it is "southeast", "northwest" etc. (all lowercase no space and no quotes).

In the section for:
now open lang/english.php
find
$lang_config_php
and add

  'wm_bottomright' => 'Bottom right',
  'wm_bottomleft' => 'Bottom left',
  'wm_topleft' => 'Up left',
  'wm_topright' => 'Up Right',
  'wm_center' => 'Center',
  'wm_both' => 'Both',
  'wm_original' => 'Original',

I think you should have also included:

  'wm_resized' => 'resized',

as you have us modify that in the:

function form_watermark


I also noticed that my "O" when I deleted a file didn't have a definition it looked like this:

F : full size image
N : normal size image
O :
T : thumbnail
C : comment
D : image in album

So I found where I needed to update that and now it displays "Original in album".

But now I have a new issue thats got me stumped.  When I do a single file upload this mod works fine.  When I do a batch add files the resized photo gets the watermark but the original doesn't.  Did I miss something to make this work because I'm unable to figure out how to get it done.

I even created a test gallery and redid every mod exactly as you typed out without changing a single line and I still have the problem in my test gallery.

If you or anyone needs access to this gallery etc to help try to fix this, then  I'll be happy to provide you with whatever you you may need.

Thanks in advance

sorry for the wm_bottomright thingie... there was a mixup with the GD only version. Don't change lang_config_php  but have another lang_config_data

'Image watermarking',
array('Watermark Image', 'enable_watermark', 1),
array('Where to place the watermark', 'where_put_watermark', 11),
array('Which files to watermark', 'which_files_to_watermark', 12),
array('Which file to use for watermark', 'watermark_file', 0),
array('Transparency 0-100 for entire image', 'watermark_transparency', 0),
array('Set color transparent x (GD2 only)', 'watermark_transparency_featherx', 0),
array('Set color transparent y (GD2 only)', 'watermark_transparency_feathery', 0),


Yes, I've forgotten the last line   'wm_resized' => 'resized',

both things fixed above as well as the typo in delete.php


OK, when you upload a pic (let's say mypicture.jpg) then you have three versions: normal_mypicture.jpg (has watermark), mypicture.jpg (has watermark and is the fullsize image) and orig_mypicture.jpg (no watermark cause that's the backup file in case you want to undo watermarking). This all should work perfect with normal upload, batch modify und batch upload... at least here it does ;)

QuoteK, when you upload a pic (let's say mypicture.jpg) then you have three versions: normal_mypicture.jpg (has watermark), mypicture.jpg (has watermark and is the fullsize image) and orig_mypicture.jpg (no watermark cause that's the backup file in case you want to undo watermarking). This all should work perfect with normal upload, batch modify und batch upload... at least here it does Wink

When I use "Upload file" it places the pictures in \userpics\10001 and I have 4 versions (everything from above and the thumb_ but thats not apart of this script and I understand that).  The mypicture.jpg is the original with the watermark, and has a modified date of the day I uploaded it.

When I do a batch add files I get the same 4 files, in the folder i ftp'd the original into, however it wasn't modified with the watermark.  So basically I have mypicture.jpg and i have orig_mypicture.jpg that are identical.  The script never watermarked mypicture.jpg.  mypicture.jpg still has the original file date when it was taken, not the date it was batched through like the 3 new files.


**Edit**
My pictures were not set to read/write.  I did a chmod 666 for each of the pictures and then did a batch upload and it worked peachy.

I would like to know if there is a way to make it so when I do a batch upload I don't get the broken picture links that are for the "DP" signs.  I would like them to show "OK" signs since they are uploading successfully, but that really is nitpicky I'm sure.

I did add one other thing to your script though for my own likes.

In picmgmt.inc.php I added this in the section where you are setting the cooridnates where the watermark will show up.
else if ($pos == "southcenter") {
$src_x = ($destWidth/2) - ($logoW/2);
$src_y = ($destHeight/2) - $logoH + 70;
}

The number 70 after $logoH slides the watermark down 70 pixels.  I prefer this over having a watermark right in the center as most head shot pictures would have the watermark right across the face.  Ofcourse you can change the number 70 to whatever suits your needs to move the watermark around.

does mypicture.jpg and orig_mypicture.jpg have a different file size?

I am EXTREMELY frustrated. 

I have been trying to get my 1.2.1 upgraded to 1.3.3 all day long.  This was supposed to take 30 minutes this morning!!!!

I cannot seem to figure out what the problem is, but picmgmt.inc.php and upload.php don't seem to play nice once this watermarking hack is installed on version 1.3.3.  I will continue to beat on it, but for now, I am going to keep the old 1.3.2 version of picmgmt.inc.php to do the dirty work of watermarking. 

very, very, very frustrated.

picmgmt.inc.php are identical for 1.3.2 and 1.3.3 except one lil chmod thing. So just use the modified version on top.
If you want the lil change then search for
@mkdir($CONFIG['fullpath'].'edit',0666);
and replace 0666 with 0777

Quote from: bangerkcknbck on April 21, 2005, 09:16:40 AM
freesouljah:
Thanks for your time to post a response.  I had already looked at the thread from Burpee where he noted to do the sql with phpmyadmin or webmin.  It then made sense.  I used webmin and  I did have to modify

Code Select Expand

cpg_config
To say what fit my database table like this:

Code Select Expand

cpg132_config

I now have the watermark setup working but never ran into the upload issues you have.  May I suggest trying with a vanilla install of CPG and a clean database then start the mods over?

it may have something to do with the phpbb bridge....I will try it once more....and if I don't get it working, I will give it up and try a different watermark mod.

Is it suppose to automatically watermark for batch upload only? because It doesnt add a watermark thats added through the regular upload process.

Quote from: cdrake on May 03, 2005, 12:26:30 AM
Is it suppose to automatically watermark for batch upload only? because It doesnt add a watermark thats added through the regular upload process.

May I suggest reading post #44?  I could watermark on single picture upload, but had to chmod the files to 666 on batch.  Both processes work just fine.

Just a Question with the mod....

Everything works fine.... but I have come across with one small problem.. it seems to not be watermaking the pics that dont need a resize

Like if I upload a pic that is larger than what it will show, it will resize it, and create the 4 files as mentioned in above posts.

But when you upload a pic that is not going to be resized as its smaller than the resize settings, it does not watermark
any of the pics and the "normal_mypicture.jpg" is missing completely. Only "mypicture.jpg" and "orig_mypicture.jpg"
are uploaded into the folder (as well as the thumb). The "mypicture.jpg" does not get watermarked at all....

As I said it works fine for when you upload an oversized picture, but not for non resized pictures.

Anyhelp would be appreciated to maybe a slolution for this prob. Thanks is advance.

Quote from: Dice on June 13, 2005, 07:31:22 AM
But when you upload a pic that is not going to be resized as its smaller than the resize settings, it does not watermark
any of the pics and the "normal_mypicture.jpg" is missing completely.

uhps... sorry
It's fixed now. Please update your picmgmt.inc.php

and I've written a lil addition for batch changes so you won't have to click for each bunch the submit button. With a few thousand images that'll need ages. Now it's 'auto pressing' it and you just run the batch process and leave it running till it's finished. If anyone needs it...

Quote from: Stramm on June 13, 2005, 10:33:45 AM
uhps... sorry
It's fixed now. Please update your picmgmt.inc.php

Thanks so much Stramm, you fixed that so quick....
Works perfectly now....

Big thanks to all the work that you have put into this mod....  ;D

Quote from: Stramm on March 26, 2005, 06:39:12 PM
now delete.php

find a block similar to the one below and replace (just colspan has been adjusted)

Code Select Expand

    // Picture

    case 'picture':
        if (!(GALLERY_ADMIN_MODE || USER_ADMIN_MODE)) cpg_die(ERROR, $lang_errors['access_denied'], __FILE__, __LINE__);

        $pid = (int)$HTTP_GET_VARS['id'];

        pageheader($lang_delete_php['del_pic']);
        starttable("100%", $lang_delete_php['del_pic'], 7);
        output_table_header();
        $aid = delete_picture($pid);
        output_caption();
        echo "<tr><td colspan=\"7\" class=\"tablef\" align=\"center\">\n";
        echo "<div class=\"admin_menu_thumb\"><a href=\"thumbnails.php?album=$aid\"  class=\"adm_menu\">$lang_continue</a></div>\n";
        echo "</td></tr>\n";
        endtable();
        pagefooter();
        ob_end_flush();
        break;



do the same with this block

Code Select Expand

<tr>
<td class="tableh2"><b>Picture</b></td>
<td class="tableh2" align="center"><b>F</b></td>
<td class="tableh2" align="center"><b>N</b></td>
<td class="tableh2" align="center"><b>O</b></td>
<td class="tableh2" align="center"><b>T</b></td>
<td class="tableh2" align="center"><b>C</b></td>
<td class="tableh2" align="center"><b>D</b></td>
</tr>
<?php
}

function output_caption()
{
    global $lang_delete_php
    ?>
<tr><td colspan="7" class="tableb">&nbsp;</td></tr>
<tr><td colspan="7" class="tableh2"><b><?php echo $lang_delete_php['caption'] ?></b></tr>
<tr><td colspan="7" class="tableb">
<table cellpadding="1" cellspacing="0">
<tr><td><b>F</b></td><td>:</td><td><?php echo $lang_delete_php['fs_pic'] ?></td><td width="20">&nbsp;</td><td><img src="images/green.gif" border="0" width="12" height="12" align="absmiddle"></td><td>:</td><td><?php echo $lang_delete_php['del_success'] ?></td></tr>
<tr><td><b>N</b></td><td>:</td><td><?php echo $lang_delete_php['ns_pic'] ?></td><td width="20">&nbsp</td><td><img src="images/red.gif" border="0" width="12" height="12" align="absmiddle"></td><td>:</td><td><?php echo $lang_delete_php['err_del'] ?></td></tr>
<tr><td><b>O</b></td><td>:</td><td><?php echo $lang_delete_php['orig_pic'] ?></td></tr>
<tr><td><b>T</b></td><td>:</td><td><?php echo $lang_delete_php['thumb_pic'] ?></td></tr>
<tr><td><b>C</b></td><td>:</td><td><?php echo $lang_delete_php['comment'] ?></td></tr>
<tr><td><b>D</b></td><td>:</td><td><?php echo $lang_delete_php['im_in_alb'] ?></td></tr>
</table>
</td>
</tr>


I don't quite understand this.  You use the same code twice in delete.php??  or do you replace the 2nd code with the one on this page?

Quote from: rcsmith on June 21, 2005, 07:08:39 PM
I don't quite understand this.  You use the same code twice in delete.php??  or do you replace the 2nd code with the one on this page?

have a look at the first code block... now look for a similar one in delete.php and replace the found one with the one shown here. When done look at the second code block, find something similar in delete.php and replace with the given one here. As said, only lil changes here in the table layout to have two more cells.

Stramm

The mod you have posted. Is that MOD complete? Is it a MOD without typos, missing lines and so forth? I ask this because I have installed your mod and I get no errors what so ever. But it doesn't add the watermark either. I have tried it under imagemagick, and GD2. I am running CPG133. I have read every message in this database about your MOD and I can't find anything that might help. Pleeeeeeease Help me or I'm going into the garage and find a beam.

BTW Great work. You have obviously put a lot of effort in to this MOD.

Regards
Don

Have you added the SQL? And you've entered the absolute path to the wm image?

When modifying the config and you check after saving it... this works?

Stramm

Yes, I added the SQL, used the complete server path and the information saves in the config. Let me through this in the mix. My SQL prefix is djmac200_config. I also tried Burpee's MOD first and that didn't work either. Then I seen your MOD and felt it would better suit my needs. Let me know if you need to get into it and I will PM you with anything you need.

Regards
Don

to me it looks like you haven't added the mysql statements correctly... a wrong absolute path would spit out an error after uploading and not show the pic at all. A problem with the mysql would just upload the pic without watermark... ;)

I dunno how you added the mysql stuff... but something went wrong (that's my guess)

Stramm

OK That is a possibility. What I did was create a txt file with the parameters and installed the tables that way. It looked like it setup correctly. I will take out the tables and re-install them again. But this time I will do it one at a time. I'll let you know how I make out.

Thanks

and Regards
Don

Stramm

OK I got it! It works.... I knew it was something so obvious if it had teeth it would have bit me. In the config under Transparency 0-100 for entire image I had 0, zip, nadda... Sometimes you have to smack me to get my attention.....

Thank you for your patience and your time.

Regards
Don

uhhmm.. OK... I should have said to use something like 50 to test it, hahaha

Hey there Stramm, first off thanks for the great mod .. am running into problems though and after 2 days still can't get around it.

Would you mind reading This Thread (http://forum.coppermine-gallery.net/index.php?topic=19212.0) and possibly offering a solution?

Much thanks.

With the duplicates I can't help you. That's related to coppermine itself. I even didn't know coppermine shows duplicates (shame about me). I just know it renames files if the same filename's already present.

For the watermarking... have you set 'Which files to watermark' to => both??

When you use the 'Tools', you can recreate fullsized and normal pics... does that work?

Hi!
Just applied the hack, but util.php gives me this:
Warning: chmod(): Operation not permitted in /var/www/test/bilder/include/picmgmt.inc.php on line 281
albums/userpics/10001/thumb_100_1303.jpg oppdateringen var vellykket!
albums/userpics/10001/normal_100_1303.jpgoppdateringen var vellykket!

Warning: chmod(): Operation not permitted in /var/www/test/bilder/include/picmgmt.inc.php on line 281
albums/userpics/10001/thumb_100_1299.jpg oppdateringen var vellykket!
albums/userpics/10001/normal_100_1299.jpgoppdateringen var vellykket!

Warning: chmod(): Operation not permitted in /var/www/test/bilder/include/picmgmt.inc.php on line 281
albums/userpics/10001/thumb_100_1298.jpg oppdateringen var vellykket!
albums/userpics/10001/normal_100_1298.jpgoppdateringen var vellykket!

Warning: chmod(): Operation not permitted in /var/www/test/bilder/include/picmgmt.inc.php on line 281
albums/userpics/10001/thumb_100_1297.jpg oppdateringen var vellykket!
albums/userpics/10001/normal_100_1297.jpgoppdateringen var vellykket!

singlefile upload gives no error, but again, it does not get the watermark. What can this be?

looks like chmod for files isn't set properly in your coppermine config. 666 should work for most environments.

To fix the permissions of the already uploaded pics SSH into your box go to your cpg/albums/userpics/10001 directory and type

chmod -R 666 *
(you may need root access to do that)
if you have other directories in userpics like 10002 do the same in there as well

It works when uploading new pics cause then no file exists. Later, in the batch tool coppermine tries to change the pics but your OS doesn't allow coppermine to do so. Therefore the 'operation not permitted'

I tried this hack and everything "seemed" to work fine. BUT the image quality was horrible. I am not sure exactly why. If you want to see an example go here:
http://michellekwan.net/gallery/thumbnails.php?album=1

I tried messing around with the settings and nothing really helped. FYI, all the images were clear and clean before upload. I uploaded two of the same picture. One with the hack install, one after I took it off.  It is obviously compressing the photos (600k vs 100k). I don't WANT it too. Seemed like it was a "feature" by the creator but I have more bandwidth then I could ever use so I could careless about saving it. Is there a way to disable it?

adding a watermark means applying an image to your existing one and processing/ recompressing the entire newly created image again. If your base material is from minor quality or already compressed to the limit you'll get bad results. That should be clear to everyone.

The hack uses the settings in your config. So you can try to raise image quality there to avoid more compression. Or you switch to another image manipulation tool... IMagick instead of GD2 or vice versa. I think it was IMagick that needed two steps to create a watermarked image versus one step with GD2.

Config was set to 100. I tried both GD2 and IM. Do have an example site where this actually working well?

I have a live site up but it's adult... here a test pic. A fishtank I've sold on ebay. Pic downloaded from ebay, you still can see their watermark. Mine is in the center, jpg quality 80, IM, transparency 40
Watermark: Arial bold, font color blue, outline 1px gray

I finally got around to re-installing this sweet mod...and it worked this time  ;D


one thing that could be useful in later versions would be an option to use the watermark or not while uploading.....not a complaint, but a suggestion....

thanks again  8)

Quote from: freesouljah on July 13, 2005, 08:11:24 AM
one thing that could be useful in later versions would be an option to use the watermark or not while uploading.....

So that each uploader (guest, registered, admin) can disable watermarking for his own uploads?? What for should that be?

Quote from: Stramm on July 13, 2005, 08:52:18 AM

Quote from: freesouljah on July 13, 2005, 08:11:24 AM
one thing that could be useful in later versions would be an option to use the watermark or not while uploading.....

So that each uploader (guest, registered, admin) can disable watermarking for his own uploads?? What for should that be?

Mainly Admin...at least in my case.  In my galleries, I have images that were taken by me and other photogs exclusively for our site...and that is when I would want to use the watermark (most likely in batch add).  But then the rest of the galleries are user contributions, which I don't want to add the watermark to.  So at the moment, when I want to use the watermark, I turn it on in Admin....do a batch add...and then shut it off again.

Thanks

it's easy to do... but I haven't tested it that's your job, heheh

Quote from: Stramm on July 14, 2005, 12:39:40 PM
that's your job, heheh

that it is  ;)

I will let you know how it goes...


Thanks again  ;D

I get this error  ???

QuoteParse error: parse error, unexpected T_IF, expecting ')' in /home/staticp/public_html/photos/upload.php on line 925

line 925 is:

      if (USER_IS_ADMIN) {

change the line above to

array($lang_upload_php['keywords'], 'keywords', 0, 255, 1));

now it says:

QuoteParse error: parse error, unexpected T_IF in /home/staticp/public_html/photos/upload.php on line 925

OK, lol...just for you I've installed this modmod on my test machine....

it's one lil mistake. Happened cause I'm already using a modded upload php

so here you go... find in upload php

   $form_array = array(
   array($lang_upload_php['album'], 'album', 2),
   array($lang_upload_php['pic_title'], 'title', 0, 255, 1),
   array($captionLabel, 'caption', 3, $CONFIG['max_img_desc_length']),
   array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),
   array('control', 'phase_2', 4),
   array('unique_ID', $_POST['unique_ID'], 4),
   );


replace with

   $form_array = array(
   array($lang_upload_php['album'], 'album', 2),
   array($lang_upload_php['pic_title'], 'title', 0, 255, 1),
   array($captionLabel, 'caption', 3, $CONFIG['max_img_desc_length']),
   array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),
   array('control', 'phase_2', 4),
   array('unique_ID', $_POST['unique_ID'], 4),
   );

if (USER_IS_ADMIN) {
$form_array[] = array($lang_upload_php['disable_admin_watermark'], 'disable_admin_watermark', 5);
}


I've corrected this above as well

Your method works like a charm! Everything is OK and I am quite pleased with the result. ;)

Only one question. Can I apply the watermark to the already uploaded pictures?  ::)

Quote from: xb00t on July 21, 2005, 02:53:24 PM
Your method works like a charm! Everything is OK and I am quite pleased with the result. ;)

Only one question. Can I apply the watermark to the already uploaded pictures?  ::)

yes... try the admin tools -> Update thumbs and/or resized photos -> Both normal and full sized (if a orig copy is available)
the standard coppermine function isn't that good if you have loads of pics. If you do have more then ~500 tell me and I'll post my batch modify mod

It seems to be working pretty fine except the fact that for some reason I cant change the CHMOD to some of my pics and CPG can't update them. It works works for some of them. @_@ The wierdest thing is that my FTP client wont change the CHMOD aswel. And I am root. ???

if you're root, you should know: CHOWN before CHMODing...
However, the root account shouldn't be used for FTPing.

Quote from: GauGau on July 22, 2005, 08:28:22 AM
However, the root account shouldn't be used for FTPing.

for security reasons you should go even further and configure root not to be able to login using ftp, ssh, ssh2 or whatever. Most secure is to use a standard user to login and then su. This way an attacker will need to break two walls

And some FTP clients have problems with chown, chmod. Use ssh, that works

There seems to be an issue with having watermarks on Resized images only. I have added this mod to an unmodified coppermine 1.3.3

It works fine if I select watermarks for both images but no watermark appears for just resized images. Any suggestions?

Also when I select the option to watermark the originals only it watermarks the resized and original image.

you're right... thanks for mentioning it. Looks like with the last bugfix a few if statements mixed up

just replace your picmgmt.inc.php with the new one

That's a lil hack for the watermark mod. If you want certain users to have their own watermark then it's for you

How to use it?
Just FTP a new watermark file into the dir where your main watermark file already is. It's name should be the username it is for. On nix boxes it's case sensitive. It has to be png.
Eg. the user you want to have an own watermark for is 'MadDog'... then the watermark file needs to be named 'MadDog.png'. When this user now uploads, that watermark will be used for his pictures. Pictures uploaded by other users will get the standard watremark. To remove special watermarks for a certain user, just delete his watermark file.

Warning: when using the admin tools to change/ modify watermarks all special watermarks will get replaced with the standard watermark. If the logged in admin has a special watermark this will be used then.

here's the new picmgmt.inc.php


<?php
// ------------------------------------------------------------------------- //
// Coppermine Photo Gallery 1.3.2                                            //
// ------------------------------------------------------------------------- //
// Copyright (C) 2002-2004 Gregory DEMAR                                     //
// http://www.chezgreg.net/coppermine/                                       //
// ------------------------------------------------------------------------- //
// Updated by the Coppermine Dev Team                                        //
// (http://coppermine.sf.net/team/)                                          //
// see /docs/credits.html for details                                        //
// ------------------------------------------------------------------------- //
// This program is free software; you can redistribute it and/or modify      //
// it under the terms of the GNU General Public License as published by      //
// the Free Software Foundation; either version 2 of the License, or         //
// (at your option) any later version.                                       //
// ------------------------------------------------------------------------- //
// CVS version: $Id: picmgmt.inc.php,v 1.8 2004/07/27 13:58:04 oddeveloper Exp $
// ------------------------------------------------------------------------- //

// Add a picture to an album
function add_picture($aid, $filepath, $filename, $title = '', $caption = '', $keywords = '', $user1 = '', $user2 = '', $user3 = '', $user4 = '', $category = 0, $raw_ip = '', $hdr_ip = '',$iwidth=0,$iheight=0)
{
    global $CONFIG, $ERROR, $USER_DATA, $PIC_NEED_APPROVAL;
    global $lang_errors;

    $image = $CONFIG['fullpath'] . $filepath . $filename;
    $normal = $CONFIG['fullpath'] . $filepath . $CONFIG['normal_pfx'] . $filename;
    $thumb = $CONFIG['fullpath'] . $filepath . $CONFIG['thumb_pfx'] . $filename;
    $orig = $CONFIG['fullpath'] . $filepath . $CONFIG['orig_pfx'] . $filename;
$work_image = $image;
    if (!is_known_filetype($image)) {
        return false;
    } elseif (is_image($filename)) {
if (!file_exists($orig) && $CONFIG['enable_watermark'] == '1' && ($CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'original'))  {
// if copy of full_sized doesn't exist and if watermark enabled and if fullsized pic watermark=true -> then we need a backup
if (!copy($image, $orig))
                return false;
else
$work_image = $orig;
}
        if (!file_exists($thumb)) {
            if (!resize_image($work_image, $thumb, $CONFIG['thumb_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "false"))
                return false;
        }
        $imagesize = getimagesize($work_image);
        if (max($imagesize[0], $imagesize[1]) > $CONFIG['picture_width'] && $CONFIG['make_intermediate'] && !file_exists($normal)) {
            if ($CONFIG['enable_watermark'] == '1' && $CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'resized'){
if (!resize_image($work_image, $normal, $CONFIG['picture_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "true"))
                 return false;
}
else {
if (!resize_image($work_image, $normal, $CONFIG['picture_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "false"))
            return false;
}
}
/*else {
if (!resize_image($work_image, $normal, $CONFIG['picture_width'], $CONFIG['thumb_method'], $CONFIG['thumb_use'], "false"))
                return false;

}*/
        $imagesize = getimagesize($work_image);
        if ($CONFIG['enable_watermark'] == '1' && $CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'original'){
if (!resize_image($work_image, $image, $imagesize[0], $CONFIG['thumb_method'], 'orig', 'true'))
                 return false;
}
    } else {
        $imagesize[0] = $iwidth;
        $imagesize[1] = $iheight;
    }


    $image_filesize = filesize($image);
    $total_filesize = is_image($filename) ? ($image_filesize + (file_exists($normal) ? filesize($normal) : 0) + filesize($thumb)) : ($image_filesize);


    // Test if disk quota exceeded
    if (!GALLERY_ADMIN_MODE && $USER_DATA['group_quota']) {
        $result = db_query("SELECT sum(total_filesize) FROM {$CONFIG['TABLE_PICTURES']}, {$CONFIG['TABLE_ALBUMS']} WHERE  {$CONFIG['TABLE_PICTURES']}.aid = {$CONFIG['TABLE_ALBUMS']}.aid AND category = '" . (FIRST_USER_CAT + USER_ID) . "'");
        $record = mysql_fetch_array($result);
        $total_space_used = $record[0];
        mysql_free_result($result);

        if ((($total_space_used + $total_filesize)>>10) > $USER_DATA['group_quota'] ) {
            @unlink($image);
            if (is_image($image)) {
                @unlink($normal);
                @unlink($thumb);
            }
            $msg = strtr($lang_errors['quota_exceeded'], array('[quota]' => ($USER_DATA['group_quota']),
                '[space]' => ($total_space_used >> 10)));
            cpg_die(ERROR, $msg, __FILE__, __LINE__);
        }
    }
    // Test if picture requires approval
    if (GALLERY_ADMIN_MODE) {
        $approved = 'YES';
    } elseif (!$USER_DATA['priv_upl_need_approval'] && $category == FIRST_USER_CAT + USER_ID) {
        $approved = 'YES';
    } elseif (!$USER_DATA['pub_upl_need_approval']) {
        $approved = 'YES';
    } else {
        $approved = 'NO';
    }
    $PIC_NEED_APPROVAL = ($approved == 'NO');
    // User ID is now recorded when in admin mode (casper)
    $user_id = USER_ID;
    $username= USER_NAME;
    $query = "INSERT INTO {$CONFIG['TABLE_PICTURES']} (pid, aid, filepath, filename, filesize, total_filesize, pwidth, pheight, ctime, owner_id, owner_name, title, caption, keywords, approved, user1, user2, user3, user4, pic_raw_ip, pic_hdr_ip) VALUES ('', '$aid', '" . addslashes($filepath) . "', '" . addslashes($filename) . "', '$image_filesize', '$total_filesize', '{$imagesize[0]}', '{$imagesize[1]}', '" . time() . "', '$user_id', '$username','$title', '$caption', '$keywords', '$approved', '$user1', '$user2', '$user3', '$user4', '$raw_ip', '$hdr_ip')";
    $result = db_query($query);

    return $result;
}

define("GIS_GIF", 1);
define("GIS_JPG", 2);
define("GIS_PNG", 3);

// Add 'edit' directory if it doesn't exist
// Set access to read+write only
if (!is_dir($CONFIG['fullpath'].'edit')) {
    $cpg_umask = umask(0);
    @mkdir($CONFIG['fullpath'].'edit',0666);
    umask($cpg_umask);
    unset($cpg_umask);
}

/**
* resize_image()
*
* Create a file containing a resized image
*
* @param  $src_file the source file
* @param  $dest_file the destination file
* @param  $new_size the size of the square within which the new image must fit
* @param  $method the method used for image resizing
* @return 'true' in case of success
*/
function resize_image($src_file, $dest_file, $new_size, $method, $thumb_use, $watermark="false")
{
    global $CONFIG, $ERROR;
    global $lang_errors;

    if ($watermark == "true"){
        $path_parts = pathinfo($CONFIG['watermark_file']);
        if (file_exists($path_parts["dirname"]."/".(USER_NAME).".png")) $wm_file = $path_parts["dirname"]."/".(USER_NAME).".png";
        else $wm_file = $CONFIG['watermark_file'];
    }

    $imginfo = getimagesize($src_file);
    if ($imginfo == null)
        return false;
        // GD can only handle JPG & PNG images
    if ($imginfo[2] != GIS_JPG && $imginfo[2] != GIS_PNG && ($method == 'gd1' || $method == 'gd2')) {
        $ERROR = $lang_errors['gd_file_type_err'];
        return false;
    }
    // height/width
    $srcWidth = $imginfo[0];
    $srcHeight = $imginfo[1];
    if ($thumb_use == 'ht') {
        $ratio = $srcHeight / $new_size;
    } elseif ($thumb_use == 'wd') {
        $ratio = $srcWidth / $new_size;
    } else {
        $ratio = max($srcWidth, $srcHeight) / $new_size;
    }
    $ratio = max($ratio, 1.0);
if ($thumb_use == 'orig') $ratio=1.0;
    $destWidth = (int)($srcWidth / $ratio);
    $destHeight = (int)($srcHeight / $ratio);
    // Method for thumbnails creation
    switch ($method) {
        case "im" :
            if (preg_match("#[A-Z]:|\\\\#Ai", __FILE__)) {
                // get the basedir, remove '/include'
                $cur_dir = substr(dirname(__FILE__), 0, -8);
                $src_file = '"' . $cur_dir . '\\' . strtr($src_file, '/', '\\') . '"';
                $im_dest_file = str_replace('%', '%%', ('"' . $cur_dir . '\\' . strtr($dest_file, '/', '\\') . '"'));
            } else {
                $src_file = escapeshellarg($src_file);
                $im_dest_file = str_replace('%', '%%', escapeshellarg($dest_file));
            }

            $output = array();
$anno_txt="";
$annotate="";

            /*
             * Hack for working with ImageMagick on WIndows even if IM is installed in C:\Program Files.
             * By Aditya Mooley <aditya@sanisoft.com>
             */

                $cmd = "{$CONFIG['impath']}convert -quality {$CONFIG['jpeg_qual']} {$CONFIG['im_options']} -geometry {$destWidth}x{$destHeight} $annotate $src_file $im_dest_file";
exec ($cmd, $output, $retval);
if ($watermark == "true"){
$cmd = "{$CONFIG['impath']}composite -dissolve {$CONFIG['watermark_transparency']} -gravity {$CONFIG['where_put_watermark']} {$wm_file} $im_dest_file $im_dest_file";
exec ($cmd, $output, $retval);
             }

            if ($retval) {
                $ERROR = "Error executing ImageMagick - Return value: $retval";
                if ($CONFIG['debug_mode']) {
                    // Re-execute the command with the backtit operator in order to get all outputs
                    // will not work is safe mode is enabled
                    $output = `$cmd 2>&1`;
                    $ERROR .= "<br /><br /><div align=\"left\">Cmd line : <br /><font size=\"2\">" . nl2br(htmlspecialchars($cmd)) . "</font></div>";
                    $ERROR .= "<br /><br /><div align=\"left\">The convert program said:<br /><font size=\"2\">";
                    $ERROR .= nl2br(htmlspecialchars($output));
                    $ERROR .= "</font></div>";
                }
                @unlink($dest_file);
                return false;
            }
            break;

        case "gd1" :
            if (!function_exists('imagecreatefromjpeg')) {
                cpg_die(CRITICAL_ERROR, 'PHP running on your server does not support the GD image library, check with your webhost if ImageMagick is installed', __FILE__, __LINE__);
            }
            if ($imginfo[2] == GIS_JPG)
                $src_img = imagecreatefromjpeg($src_file);
            else
                $src_img = imagecreatefrompng($src_file);
            if (!$src_img) {
                $ERROR = $lang_errors['invalid_image'];
                return false;
            }
            $dst_img = imagecreate($destWidth, $destHeight);
            imagecopyresized($dst_img, $src_img, 0, 0, 0, 0, $destWidth, (int)$destHeight, $srcWidth, $srcHeight);
            imagejpeg($dst_img, $dest_file, $CONFIG['jpeg_qual']);
            imagedestroy($src_img);
            imagedestroy($dst_img);
            break;

        case "gd2" :
            if (!function_exists('imagecreatefromjpeg')) {
                cpg_die(CRITICAL_ERROR, 'PHP running on your server does not support the GD image library, check with your webhost if ImageMagick is installed', __FILE__, __LINE__);
            }
            if (!function_exists('imagecreatetruecolor')) {
                cpg_die(CRITICAL_ERROR, 'PHP running on your server does not support GD version 2.x, please switch to GD version 1.x on the config page', __FILE__, __LINE__);
            }
            if ($imginfo[2] == GIS_JPG)
                $src_img = imagecreatefromjpeg($src_file);
            else
                $src_img = imagecreatefrompng($src_file);
            if (!$src_img) {
                $ERROR = $lang_errors['invalid_image'];
                return false;
            }
            $dst_img = imagecreatetruecolor($destWidth, $destHeight);
            imagecopyresampled($dst_img, $src_img, 0, 0, 0, 0, $destWidth, (int)$destHeight, $srcWidth, $srcHeight);
            
if ($watermark == "true"){
$logoImage = ImageCreateFromPNG($wm_file);
    $logoW = ImageSX($logoImage); 
    $logoH = ImageSY($logoImage); 
    //where is the watermark displayed...
    $pos = $CONFIG['where_put_watermark']; 
if ($pos == "northwest") { 
$src_x = 5;  
$src_y = 5; 
} else if ($pos == "northeast") { 
$src_x = $destWidth - ($logoW + 5); 
$src_y = 5; 
} else if ($pos == "southwest") { 
$src_x = 5; 
$src_y = $destHeight - ($logoH + 5); 
} else if ($pos == "southeast") { 
$src_x = $destWidth - ($logoW + 5); 
$src_y = $destHeight - ($logoH + 5); 
} else if ($pos == "center") { 
$src_x = ($destWidth/2) - ($logoW/2); 
$src_y = ($destHeight/2) - ($logoH/2); 
} 

// no, we don't support that in the script, overkill... just make a transparentbkg png and don't be so lazy
//imagecolortransparent($logoImage, imagecolorat($logoImage, $CONFIG['watermark_transparency_featherx'], $CONFIG['watermark_transparency_feathery']));
imagealphablending($dst_img, TRUE);
imagecolortransparent($logoImage, imagecolorat($logoImage, $CONFIG['watermark_transparency_featherx'], $CONFIG['watermark_transparency_feathery']));
ImageCopyMerge($dst_img,$logoImage,$src_x,$src_y,0,0,$logoW,$logoH,$CONFIG['watermark_transparency']); //$dst_x,$dst_y,0,0,$logoW,$logoH); 
}
imagejpeg($dst_img, $dest_file, $CONFIG['jpeg_qual']);
            imagedestroy($src_img);
            imagedestroy($dst_img);
            break;
    }
    // Set mode of uploaded picture
    chmod($dest_file, octdec($CONFIG['default_file_mode']));
    // We check that the image is valid
    $imginfo = getimagesize($dest_file);
    if ($imginfo == null) {
        $ERROR = $lang_errors['resize_failed'];
        @unlink($dest_file);
        return false;
    } else {
        return true;
    }
}
?>

I have updated the new picmgmt.inc.php but it still isn't applying the watermark to the resized images on the resize only option.

[ edit | actually the new picmgmt.inc.php has made no difference ]

tested again with only resized, only original, both and no watermark... works perfect. you really are using the actual version??
(I've used the version from the board to be sure it's the one it should be). In case it really doesn't work, attach your picmgm... and tell me something about your system

When having a lot of pics the standard admin tools are a pain. On production boxes with a short timeout you only can process ~5 pics at a time. When done you have to click 'continue'. Doing that for a few thousand pics is annoying as hell. So here a lil hack for it.

What it does... the script simply calls itself over and over again till all images are processed. No need to click continue. Best is to set ~5 images to process at a time. If it really should time out with these only five pics just hit the browser reload button and it continues to work. So have a coffe and a lil bit of time and all's done by itself...

in util.php find
<form action="' . $phpself . '" method="post">

replace with
<form action="updatethumbs.php" method="post">

a few lines below find
   endtable();

   print '<br />';

replace with
endtable();

print '<h2>'.$lang_util_php['select_album'].'</h2>';

   if (defined('UDB_INTEGRATION')) {
       udb_util_filloptions();
   } else {
       filloptions();
   }



   print '<br />

<form action="' . $phpself . '" method="post">';



now place the attached file in your coppermine main dir

Have fun drinking your coffee

The picmgmt.inc.php is exactly the same as the one you just updated.

I forgot to mention that it's working fine on the files I just upload but it's not working in admin tools to update images.

you should have mentioned that before :)

OK, either update 'function updatethumbs()' or apply the better admin tool hack for updating thumbs, normal and full images

if you stumble over some more bugs... you know where I am, hehehe

edit: I'm using the above mentioned hack... so I wasn't able to test the standard function. But the hack works smooth for me

Sweet, everything is working fine now!

Cheers mate,
` anCyru

Quote from: Stramm on July 19, 2005, 09:08:58 AM
OK, lol...just for you I've installed this modmod on my test machine....

it's one lil mistake. Happened cause I'm already using a modded upload php

so here you go... find in upload php

Code Select Expand

    $form_array = array(
    array($lang_upload_php['album'], 'album', 2),
    array($lang_upload_php['pic_title'], 'title', 0, 255, 1),
    array($captionLabel, 'caption', 3, $CONFIG['max_img_desc_length']),
    array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),
    array('control', 'phase_2', 4),
    array('unique_ID', $_POST['unique_ID'], 4),
    );


replace with

Code Select Expand

    $form_array = array(
    array($lang_upload_php['album'], 'album', 2),
    array($lang_upload_php['pic_title'], 'title', 0, 255, 1),
    array($captionLabel, 'caption', 3, $CONFIG['max_img_desc_length']),
    array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),
    array('control', 'phase_2', 4),
    array('unique_ID', $_POST['unique_ID'], 4),
    );

if (USER_IS_ADMIN) {
$form_array[] = array($lang_upload_php['disable_admin_watermark'], 'disable_admin_watermark', 5);
}


I've corrected this above as well

I get this error now:

QuoteParse error: parse error, unexpected ',' in /home/staticp/public_html/photos/upload.php on line 923

this may be due to a mod that I have installed in that area...
here is what I have:

        // Declare an array containing the various upload form box definitions.
        $captionLabel = $lang_upload_php['description'];
        if ($CONFIG['show_bbcode_help']) {$captionLabel .= '<hr />'.$lang_bbcode_help;}
        $form_array = array(
        sprintf($lang_upload_php['max_fsize'], $CONFIG['max_upl_size']),
        array($lang_upload_php['album'], 'album', 2),
        array('MAX_FILE_SIZE', $max_file_size, 4),
        array($lang_upload_php['picture'], 'userpicture', 1, 1),
        array($lang_upload_php['pic_title'], 'title', 0, 255, 1),
        array($captionLabel, 'caption', 3, $CONFIG['max_img_desc_length']),
        array($lang_upload_php['keywords'], 'keywords', 0, 255, 1));
        array('event', 'picture', 4),                                                        <----------------- line 923

if (USER_IS_ADMIN) {
$form_array[] = array($lang_upload_php['disable_admin_watermark'], 'disable_admin_watermark', 5);
}

        );


sorry for all the trouble  ???

also...I have noticed that sometimes the quality of the original image is crummy (it appears that the normal sized version has just been stretched out and then watermarked at a larger size)...this doesn't always happens, so I don't know if it is because of server load or what...


thanks

change
array($lang_upload_php['keywords'], 'keywords', 0, 255, 1));
to
array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),

with the ); at the end you're closing the array definition but continue in the next line with it
then as it looks that will just correct the error message you have now. Another one will show up.

The code should read...
        array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),
        array('event', 'picture', 4));

if (USER_IS_ADMIN) {
$form_array[] = array($lang_upload_php['disable_admin_watermark'], 'disable_admin_watermark', 5);
}



the pic quality stuff that sometimes happens. It's the downside of having to recompress the images. Hasn't to do anything with the load. But if you want you can email me a pic (original for sure) and I'll have a look

But I really can't give you support with other mods
The above stuff's just obvious ;)

Quote from: Stramm on July 31, 2005, 09:56:34 AM
change

Code Select Expand

array($lang_upload_php['keywords'], 'keywords', 0, 255, 1));
to

Code Select Expand

array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),

with the ); at the end you're closing the array definition but continue in the next line with it
then as it looks that will just correct the error message you have now. Another one will show up.

The code should read...

Code Select Expand

        array($lang_upload_php['keywords'], 'keywords', 0, 255, 1),
        array('event', 'picture', 4));

if (USER_IS_ADMIN) {
$form_array[] = array($lang_upload_php['disable_admin_watermark'], 'disable_admin_watermark', 5);
}



the pic quality stuff that sometimes happens. It's the downside of having to recompress the images. Hasn't to do anything with the load. But if you want you can email me a pic (original for sure) and I'll have a look

But I really can't give you support with other mods
The above stuff's just obvious ;)

cool  8)

that fixed the problem....thanks :D

on the image problem it seems to not be a problem in small batches...so for now I will use the util to fix the quality issues...but if you still want to see the image quality probs, I can post up examples for you...


on your util.php mod I get this error when I try to process the images:

QuoteParse error: parse error, unexpected $ in /home/staticp/public_html/photos/updatethumbs.php on line 160

 ???

it seems the image quality issue isn't as predictable as I thought....I just did a batch of over 100 images, and they all seemed to turn out fine...but when I went through using util.php to try to fix the issues on another batch that had the image degredation, nothing happened...

here are two pics showing the problem I am encountering:

that is strange...the original should be 700 px tall (not 524)...that is why they appear to be 'stretched out'...they actually are  ???

I'll have a look what maybe go wrong there.

To the updatethumbs.php problem... it's the board's code tag that caused the problem. I've added another linebreak that should fix the prob (related to EOT). Just repace the updatethumbs.php file

Quote from: Stramm on July 31, 2005, 04:57:59 PM
To the updatethumbs.php problem... it's the board's code tag that caused the problem. I've added another linebreak that should fix the prob (related to EOT). Just repace the updatethumbs.php file

cool..excellent work  ;D  makes it much easier...

thanks

I had a look at your pic and experimented a lil bit with it. The standard function to calculate the resize ratio won't work properly under some circumstances. That's fixed now. You'll have to update picmgmt and updatethumbs... the messed up ones can be fixed with the admin tool

now the util.php gives me a blank page when I try to update thumbs...


I finally saw what the other admin modification you made for me does...and unfortunately, it is not quite what I was hoping for.  Rather than an option for the admin to disable the watermark...I was hoping that it might be automatically disabled for anybody but the admin (or need the admin to turn it on while in batch add)...

if this is a problem...don't worry about it, its not that big of a deal...

thanks

to revert the functionality is easy... watermarking permanently off and only admin can turn it on while uploading

for now it works watermark on and admin can disable watermarking while uploding

I'll attach the updatethumbs file above to avoid board problems with the code tag again

working smooth as butter  8)


thanks once again...

How do you make it so it never backs up any files?  I have so many albums I can't get into the admin tool because my mysql will hit 100% and kill the server.  I'd like to just disable the backup process.

thanks!

the backup of the file doesn't have anything to do with your mysql load. You just need ~30% more HD space as your orig image consumes. That's it.

to remove the backup delete in picmgmnt.inc.php  (not tested... !!!!)

if (!file_exists($orig) && $CONFIG['enable_watermark'] == '1' && ($CONFIG['which_files_to_watermark'] == 'both' || $CONFIG['which_files_to_watermark'] == 'original'))  {
// if copy of full_sized doesn't exist and if watermark enabled and if fullsized pic watermark=true -> then we need a backup
if (!copy($image, $orig))
                return false;
else
$work_image = $orig;
}


something similar you'll find in util.php as well.. delete it too (that's for batch add). However I don't recommend it... maybe if you're running low on HD space. But the load is no reason at all.. and to copy once an image as backup while uploading doesn't need much resources as well. Compared to the image processing it's maybe <1%

thank you i'll give this a try.  My server only has 3% left so that's probably a problem too.

I have installed the mod and have a couple of questions/problems:

Quote- admin can disable watermarking whilst upload (checkbox added to upload form)

Which upload form?  Not in single, not in batch (I really wish batch would someday work  :\'( for more than a couple of images  -or work all the time - not when it feels like it) and I do not see an option in the Xp wizard.

QuoteSo in Admin Tools just use 'Update thumbs and/or resized photos' to apply or remove watermarks

Where is the choice to remove?  Do you just set the option to no watermark in config?

I do see where to remove all backups, just not the undo

It does watermark - so I know it is working but only for the main image - not the thumbnail and I do have 'Both" set.  It does not do it in uploading or admin tools.  Admin tools I have "Both thumbnails and resized pictures" set.  It also does not do thumbnails when I have it set to only update thumbnails.

Linux - same results with both GD and Imagemagic.  I even renamed updatethumbs and reinserted it just to try that.)

Does this not do thumbnails?

(Does anyone have a patch file for this entire setup?  That sure would be a whole lot easier then trying to figure out what and where things go  -just a little confusing at first and second read....  (I was going make a patch file, but not working correctly enough to do so yet :-[))

Quote- admin can disable watermarking whilst upload (checkbox added to upload form)

this is an additional mod. With it the admin has the possibility whilst uploading to decide not to watermark certain images. It is not part of the base mod

QuoteWhere is the choice to remove?  Do you just set the option to no watermark in config?

I haven't invented the admin tools. So it's a good idea to have a look in the manual. The admin tools just recreate images/ thumbs based on the config settings.

QuoteIt does watermark - so I know it is working but only for the main image

answer is in the first post:

QuoteWhich files to watermark - normal sized, full sized or both

Why would one want to watermark thumbnails???

The instructions in the first two posts are complete. However there are functionality hacks that aren't useful for the maiority of users (like the disabling watermarking for admin whilst upload, different watermarks for users and bettr admin tools). This additions you can find in the thread.

If you really need thumbnail watermarking and you have very basic php knowledge then you can do some copy/paste programming to adapt picmgmnt.inc.php to your needs

I thought you were saying that the restore was part of your admin tools.  Thumnails are stolen just as much as regualr pics - even would be more so if they are not watermarked - that's why I was looking for it.  Probably better that the restore it is not in the admin tools.  It makes it harder for someone to accidentally restore them.

there is a restore. Usually when you watermark an image you can't undo the watermark. If something wents wrong or your watermark just sucks, you once want to have a different sized intermediate pic... bad luck, you can't undo the changes. This mod makes a backup of the original image. So if you turn off watermarking in config and rebuild normal and fullsized pics then they won't have watermarks anymore. You can apply a new one... sure, no problem at all. If you think you don't need the backup cause all's to your likings... then you can delete them and noone has a chance to catch your backups.

As said, you can enhance the mod to watermark thumbnails too. I just think it looks disgusting and don't use that.
Yes, you should protect your work. Therefore I've written this mod. But you can do to much as well. If you annoy your visitors to much (with the ugly view of watermarked thumbs) I believe they pretty much will avoid your site.

Now I understand the restoring of the original images.  That is what I was asking.  The thumbnails - well a client asked.  they are night club promoters and people  swipe their images to put on MySpace.com  -as a thumbnail size.  They load of their home page with pictures of them.   That why he asked.

Maybe I will look at the changing that.  Have you thought of posting a patch file to do all of the manual changes in the part that you have written?  I can send one to you  - as I made an entire backup before I started as I knew I would end up setting up multiple galleries and did not want to do all that hand work again.

No, I don't have files here anymore with just the changes for the watermark mod, sorry

Problem with the thumb watermarking can be the watermark size. If chosen to big it can take up the entire thumb size. So you may want to check if you watermark a thumb or a normal/ fullsized Image. If it's a thumb then resize the watermark image before applying it.

I do have the patch file if you want it.  (I did your mod before any of the other ones on a clean install - so I know it is clean.)

If it's 1.34.. then it'll be very nice if you send me the files. Will make an install version for all my mods

I should have it for 1.34 soon.  I use Fantastico and they have not updated to 1.34 yet.  Soon, I hope....

hey I installed your hack
but when I update it in configuration
that watermark will be enabled
it doesnt really update it
and returns to set on "no" instead "yes"
like I didnt even changed it
whats the problem?
please help me
also when I go to util.php
it gives me this:
Parse error: parse error, unexpected T_LNUMBER in /home/healthnfit/domains/healthnfit.org/public_html/cpg132/util.php on line 481

looks to me like as if you haven't applied the sql or you did it wrong... have you changed the table prefix to the one you use??

what you mean
I did do the query thing in sql...

insert into cpg_config (name, value) values ('enable_watermark', '1');
insert into cpg_config (name, value) values ('where_put_watermark', 'bottomright');
insert into cpg_config (name, value) values ('watermark_file', '/your/full/path/to/logo.png');
insert into cpg_config (name, value) values ('which_files_to_watermark', 'both');
insert into cpg_config (name, value) values ('orig_pfx', 'orig_');
insert into cpg_config (name, value) values ('watermark_transparency', '0');
insert into cpg_config (name, value) values ('watermark_transparency_featherx', '0');
insert into cpg_config (name, value) values ('watermark_transparency_feathery', '0');

ohh I think I know the problem
in watermarkfile
I need to use the url to the file?
what do you mean full path?

well I did it right now
but its not updating the pics with the watermark
they are still without watermark
what to do?

fixed the error in util.php
but still not working
what it can be?
is it the png file?

I mean if you have changed the prefix cpg_ to the one you use.

The absolute path eg on windows is c:\apache\mysite.com\htdocs\cpg\images\mywatermark.png
on nix eg. /usr/home/stramm/mysite.com/htdocs/cpg/images/mywatermark.png

if you don't give it the absolute URL it (imagemagick, gd2) can't find the watermark image and therefore of course won't apply it

I will search for my absolute path

when I try to add it with my absolute path
it gives me this error:
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '/home/healthnfit/domains/healthnfit.org/public_html/cpg132/watermark.png');
ins' at line 1

as already mentioned above... you have a problem with your SQL. I've asked you if you've changed the prefix (cpg_) to the one you actually use?

so eg. change this
insert into cpg_config (name, value) values ('enable_watermark', '1');
to (if your prefix eg. is cpg134_)
insert into cpg134_config (name, value) values ('enable_watermark', '1');
or (if your prefix eg. is coppermine_)
insert into coppermine_config (name, value) values ('enable_watermark', '1');

edit: and what 'error' did you fix in util.php?? If you haven't applied the sql correctly nothing will work. But if you really found an error what about posting it here?

ok fixed the problems
but still not putting the watermark
I did change the prefix and absolute path
this is what I put in sql
insert into cpg132_config (name, value) values ('enable_watermark', '1');
insert into cpg132_config (name, value) values ('where_put_watermark', 'bottomright');
insert into cpg132_config (name, value) values ('watermark_file', '/home/healthnfit/domains/healthnfit.org/public_html/cpg132/watermark.png');
insert into cpg132_config (name, value) values ('which_files_to_watermark', 'both');
insert into cpg132_config (name, value) values ('orig_pfx', 'orig_');
insert into cpg132_config (name, value) values ('watermark_transparency', '0');
insert into cpg132_config (name, value) values ('watermark_transparency_featherx', '0');
insert into cpg132_config (name, value) values ('watermark_transparency_feathery', '0');

do I need to change anything in the cpg admin configuration of the watermark?
also about the util I just didnt edit it right but fixed it

set the watermark transparency to 100 (means off) or at least to 30-50 to see the watermarked image. Now it's fully transparent

still cant see it
whats the pixels of the watermark png file needs to be?
maybe its too "big" or something like this?

the wm size shouldn't matter at all... pm me your URL if you want. A temporary cpg admin account would be useful

check your pm box
thanks again

I just noticed that its working
but only on new uploads
how can I make all the old pics that are already in the gallery to have the watermark?

nevermind thanks
fixed it all
thank you again!
but some pics it ruins the pic quality
how can I fix it?
it pixelizing them??!?

yes, it only works on new pics.. to watermark old ones you'll have to use the admin tools.

Adding watermarks means that you'll have to compress your images a second time. This means you'll lose image detail. You won't see any difference if you use good quality source files. But if you laready have highly compressed base material this can lead to problems.

If you send me a URL I'll have a look. Best would be if you could send me the original file before watermarking

how can I remove the watermark
and get back to the orginial pics
your script ruins the quality of the pics but really ruins them

Quote
If you send me a URL I'll have a look. Best would be if you could send me the original file before watermarking

The watermark script doesn't resize anything but it has to attach the watermark and therefore needs to recompress the image. Read the Imagick documentation to learn more about this.

You can try to raise image quality in your settings.

nm
how can I get back to the originial pics without watermarks?
can you tell me please how

OK, you never say what you do... you don't send me a link that I can check the stuff, you don't send me an image to have a look at and you don't read the coppermine documentation nor have you read the first two posts of this thread...

I still guess you messed something up when applying the mod... however this way I cant help you.

To undo the watermark use the admin tools as you did to watermark your old pictures

ok thanks I can give you here original pic that it ruined it
heres good example:
http://www.healthnfit.org/cpg132/albums/userpics/normal_kobi17.jpg
this picture was ruined (pixelized)
dont know why
it has good quality on it
btw this is the original pic
without watermark

btw I already sent you admin access in pm!

This is not the orig but the normal file (already highly compressed to 17k)... still it doesn't matter and it looks sweet after watermarking.

Have a look yourself (14k after watermarking, I always use image quality 80%)
http://stramm.mine.nu/displayimage.php?pos=-102

A word to your manners. I really like to help. But it's disgusting to get abused as one's personal php advisor. If you tell me you have problems then I need some infos. With these infos I can tell you in most cases where the problem is. Now it's your turn to say if that helped you to solve your problem and what finally was the problem. This probably can help others and I won't have to answer the same stuff again and again.