coppermine-gallery.com/forum

Support => cpg1.4.x Support => Older/other versions => cpg1.4 miscellaneous => Topic started by: Makc666 on July 03, 2007, 05:37:32 PM

Title: Coppermine 1.4.12
Post by: Makc666 on July 03, 2007, 05:37:32 PM
According to my topic "Coppermine 1.4.11"
http://forum.coppermine-gallery.net/index.php?topic=44849.0
there was a change in english.php.

This lines from 1.4.11:
'help_local_version_na1' => 'Unable to extract cvs version info', //cpg1.4
'help_local_version_na2' => 'The script could not determine what cvs version the file on your webserver is. You should upload the file from your package.', //cpg1.4


were updeted in 1.4.12 this way:
'help_local_version_na1' => 'Unable to extract subversion version info', //cpg1.4
'help_local_version_na2' => 'The script could not determine what subversion (SVN) version the file on your webserver is. You should upload the file from your package.', //cpg1.4


English is not my native language, but...
I think that phrases with recurrent/repeate dwords like:
is not a good choice.

Why not to change those line in 1.4.13 to this one:
This lines from 1.4.11:
'help_local_version_na1' => 'Unable to extract svn version info', //cpg1.4
'help_local_version_na2' => 'The script could not determine what svn version the file on your webserver is. You should upload the file from your package.', //cpg1.4


From my point of view this is the best variant!

Thanks.

Title: Re: Coppermine 1.4.12
Post by: Joachim Müller on July 04, 2007, 07:13:01 AM
Merely cosmetical issues or a matter of taste. Doesn't matter that much. I only changed the text in the first place because you complained about it. I won't change it again, it's fine for me. We're reluctant to change english.php between minor releases, because they trigger other version updates such as yours for russian.php.
Title: Re: Coppermine 1.4.12
Post by: Makc666 on July 04, 2007, 11:55:32 AM
Quote from: GauGau on July 04, 2007, 07:13:01 AM
I only changed the text in the first place because you complained about it.
GauGau, I think you are wrong.
You change word:
cvs
to word:
svnversion

I complained to change word:
cvs
to word:
svn
as was made in other places.

Maybe you made a misprint? ??? As now text have in fact two words "version" one-by-one.

'help_local_version_na1' => 'Unable to extract subversion version info', //cpg1.4
'help_local_version_na2' => 'The script could not determine what subversion (SVN) version the file on your webserver is. You should upload the file from your package.', //cpg1.4
Title: Re: Coppermine 1.4.12
Post by: Tranz on July 04, 2007, 05:20:51 PM
What GauGau wrote is fine. It's kind of like "I saw a Big Bear bear", where Big Bear is a city up in the mountains in Southern California. That's what's going to happen when there are nouns in proper nouns. It sounds funny, but people might want to say it because it's funny.
Title: Re: Coppermine 1.4.12
Post by: Makc666 on July 04, 2007, 05:28:34 PM
Quote from: TranzNDance on July 04, 2007, 05:20:51 PM
What GauGau wrote is fine. It's kind of like "I saw a Big Bear bear", where Big Bear is a city up in the mountains in Southern California. That's what's going to happen when there are nouns in proper nouns. It sounds funny, but people might want to say it because it's funny.
Hm...
Maybe you are right...

As I understand that there is no difference between meanings of subversion version and svn version.
But the last one (svn version) sounds better and also looks the same as other svn related lines in english.php
Title: Re: Coppermine 1.4.12
Post by: Joachim Müller on July 05, 2007, 07:00:25 AM
Just cosmetical issues.