Mini Bug with albmgr.php in Javascript.

[bobcatt]

Hi all,

I'm using CPG with the french langage. and i've found a Javascript bug. Here is the diff to correct it.
(diff -uN albmgr.php.org albmgr.php)

IMO all javascript should use a " and not ' actually it's not.

Thanks

Code Select Expand


--- albmgr.php.org      2004-03-20 13:36:15.000000000 +0100
+++ albmgr.php  2004-03-20 13:37:41.000000000 +0100
@@ -53,7 +53,7 @@
 
             if (album.action != '0') {
                 if (album.album_nm == '') {
-                    alert('<?php echo $lang_albmgr_php['alb_need_name'&#93; ?>');
+                    alert("<?php echo $lang_albmgr_php['alb_need_name'&#93; ?>");
                     frm.to.options[i].selected = true;
                     return false;
                 }
@@ -65,7 +65,7 @@
             changed = true;
 
         if (changed) {
-            if (confirm('<?php echo $lang_albmgr_php['confirm_modifs'&#93; ?>')) {
+            if (confirm("<?php echo $lang_albmgr_php['confirm_modifs'&#93; ?>")) {
                 for (i=0; i<select_len; i++) {
                     album = new parseSelectValue(frm.to, i);
                     if (album.action != '0') {
@@ -78,7 +78,7 @@
                 return false;
         }
         else {
-            alert('<?php echo $lang_albmgr_php['no_change'&#93; ?>');
+            alert("<?php echo $lang_albmgr_php['no_change'&#93; ?>");
             return false;
         }
     }


[Joachim Müller]

without looking into this at all, I think you have discovered the known bug in the french language file that has been reported quite often already and that has been fixed with the most recent french language file: http://prdownloads.sourceforge.net/coppermine/cpg1.2.1lang_french.zip?download

GauGau