small php-syntax errors small php-syntax errors
 

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Main Menu

small php-syntax errors

Started by Andi, December 24, 2004, 01:23:14 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Andi

Hi :)

in
searchnew.php,v 1.39 2004/12/12 10:24:05 gaugau
and
picmgr.php,v 1.11 2004/12/19 03:43:07 nibbler999

are some small syntax-errors like this sample:
$listArray[$list_count][cat] = $lang_search_new_php['albums_no_category'];
$listArray[$list_count][aid] = $row['aid'];
$listArray[$list_count][title] = $row['title'];

correct is:
$listArray[$list_count]['cat'] = $lang_search_new_php['personal_albums'];
$listArray[$list_count]['aid'] = $row['aid'];
$listArray[$list_count]['title'] = $row['title'];


EDIT:

and this:
        foreach ($listArray as $val) {
            if ($val[cat] != $alb_cat) {
          if ($alb_cat) $select .= "</optgroup>\n";
                $select .= '<optgroup label="' . $val[cat] . '">' . "\n";
                $alb_cat = $val[cat];
            }
            $select .= '<option value="' . $val[aid] . '"' . ($val[aid] == $sel_album ? ' selected' : '') . '>   ' . $val[title] . "</option>\n";


::: $val['cat'] / $val['aid']  /  $val['title']
hope, I could help you... :)

Joachim Müller

fixed in searchnew.php v1.41 and picmgr.php v1.12. As usual: well spotted, thanks for your hard work squashing those bugs :D.

Joachim

Tranz

#2
Seriously... I'm in awe of Andi's meticulousness. :) (https://coppermine-gallery.com/forum/proxy.php?request=http%3A%2F%2Ftu2.net%2Fforums%2Fimages%2Fsmiles%2Ficon_thumbs_up.gif&hash=c577483a9e561407c273604320459d4fbbe4c4da)

Joachim Müller

@Thu: hehe, had to look this word up ;)
@Andi: meticulousness means "Akribie", "(peinliche) Genauigkeit"

;D GauGau

Tranz

I struggled to find just the right word to describe Andi's amazing ability so that was what came to mind. :)

Tarique Sani

Yes, Andi is indeed being really meticulous - Thanks Andi
SANIsoft PHP applications for E Biz

Andi

Quote@Andi: meticulousness means "Akribie", "(peinliche) Genauigkeit"

hehe :)

thx for this translation, i don't know this word  ::)
You know, my english is very bad....

But it's true, in this point i'm very meticulous.
That comes from the Coppermine transformation to vkpMx. I must compare every lines in a file when a new version comes from CVS. And i'm coding with php-setting error_reporting(E_ALL) to see and fix all the small errors....


ps. somewhat late
Happy New Year and best whishes to the Coppermine Team
hope, I could help you... :)