BUG/fault themes.inc.php ???

[mainpower]

Hello,

If I check the HTML code there are 2 times <b><b> ... therefor I change the following line in themes.inc.php (version 1.4.8 );

<span class="statlink"><b>{STATISTICS}</b></span>

into

<span class="statlink">{STATISTICS}</span>

I guess it's a bug/fault ..... but not sure.

Cheers,
Matthijs 

[Joachim Müller]

Cosmetical issue, not an actual bug imo. Anyway, moving accordingly...

[Paver]

I noticed this a while ago and forgot about it.  I'm not sure if I posted about it.

In any case, my thought is that the bold tags should be in the $template variable since that's display and moved out of the $statistics content.  I'll take a look and see if this makes sense.

edit: Nope, it doesn't make sense.  The statistics content is created from a language variable that puts the bold tags in where it likes.  So the original fix is the correct one.

[Paver]

Fix committed to devel.  I assume it should not be committed to stable since it's only a cosmetic fix?

edit: Oh, I already committed the changes to stable.  I noticed some other cosmetic fixes from May were committed, so is this OK?

[Paver]

Seems harmless to leave in stable.  Yes, some people may notice that their stats line is no longer all bold.  They can change it if desired in style.css (style 'statlink').

Thread marked as fixed.