Lost name when editing comments.

[boii]

i dont know if this is theme related (hardwired), but i've upgraded to 1.2 and when i edit a comment already made, it erases the name field. i assume the addition to be able to edit your name now sends an empty result to the db since thers no where to fill in/edit your name..

all edited comments' msg_author ended up as blank fields in the db.

cheers.
ken

[Tarique Sani]

Can you please try this with the default theme and confirm that this happens - Hardwired was edited once in the last days of RC1

In case you don't want your users to see the default theme you can change the theme just for yourself by adding

?theme=default to the URL of your gallery

[boii]

it happens in default too.

when you edit a comment, theres no field to edit your name, yet the name field is still sent in the UPDATE query i imagine. so it sets it to nothing.

cheers.
ken

[Tarique Sani]

Can someone confirm this from the RC2 install - I did a check on the the CVS and cannot replicate this...

[jasendorf]

I just did an upgrade from 1.1.0 to 1.2.0RC2 (not the CVS but from the actual downloaded RC2 install package) and it works fine in default and hardwired.  Must be a browser specific javascript issue.  I'm using IE6 on WinXP.

[boii]

ie6 on win2k.

my db_input.php has the right UPDATE msg_author='$msg_author', so im assuming its not being posted from displayimage.php properly.

hmm.

[Tarique Sani]

Can you post a URL

[Rodinou]

I have tried with Hardwired, XP, IE 6 SP1

Any problem.

[jasendorf]

Any problem.

Not sure what "any" problem means.  Does that mean there IS or IS NOT a problem?

[Rodinou]

Euh ... any problem = NO problem

[boii]

i tried re-uploading, displayimage.php and the hardwired theme.
but it still doesn't work.
tarique, ill pm you my url as i dont want my gallery to be public

cheers.
ken

[Rodinou]

i tried re-uploading, displayimage.php and the hardwired theme.
but it still doesn't work.
tarique, ill pm you my url as i dont want my gallery to be public

cheers.
ken

Not cool : it's very important to see our galleries, to progress together

[boii]

Not cool : it's very important to see our galleries, to progress together

are you kidding me.

cheers.
ken

[Rodinou]

No, but the project is "open source" : so you want answers, the minimum is to show us your gallery : no ?

[jasendorf]

are you kidding me.

Rod means well...  :roll:

[boii]

im sure   open soruce is one thing, ive shared code and mods with the board, i just dont think i need to share my personal life and pictures with it too  

anyhow, the other thread i created 'number of views under pictures' was 'moved', but i cant find what forum it was moved to.. anyone know ? id love a solution to that..

cheers.
ken

[Tarique Sani]

OK this is a bug. Name editing is messed up when smilies are disabled.

Someone please confirm...

[boii]

heres the fix for the bug:

in your theme.php:

find:

Code Select Expand

<!-- BEGIN edit_box_no_smilies -->

then under:

Code Select Expand

<form name="f{MSG_ID}" method="POST" action="db_input.php">
<input type="hidden" name="event" value="comment_update">
<input type="hidden" name="msg_id" value="{MSG_ID}">


add:

Code Select Expand

<tr>
         <td>
         <input type=text name=msg_author value={MSG_AUTHOR} class="textinput" size=10>
         </td>
</tr>


and now you can edt names when smilies are disabled. and it wont send a blank msg_author.

cheers.
ken

edit: obviously this only fixes the themes in which you edit the respective theme.php .. so if in th efuture you add the mod to select language/theme, it wont work unless youve corrected all the theme.php's. oh and ive only done the above for hardwired and never looked at another theme's theme.php file, if they have a different structure.. then make the approporate chnage by lookign above that codeblock no comment editing with enabled smilies and see how its done.

[jasendorf]

It's a little more involved than that...

gotta fix up the row tags...

Actual fix should be something like:

Code Select Expand


  <td>
    <input type=text name=msg_author value={MSG_AUTHOR} class="textinput" size=10>
  </td>
</tr>
<tr>


To close the previous row tag (above the text marked as "after") and start the subsequent row tag.

[lasa]

No, the actual fix should be something like this :

Code Select Expand

                                               <input type="hidden" name="msg_author" value="{MSG_AUTHOR}">


Laurens.