IMPROVEMENTS to 1.3.2: with CVS changes

[MrPete]

Here's a set of features we've added to Coppermine, with associated CVS changes. Please see attached zip, which is based on the current (stable) CVS. We've been running with these changes for several months.

Some of these are Bug Fixes, not new features, but it's mostly features...

Except for any new file(s), you will find *two* files for each submitted change:
   - the changed php (or sql or...) file
   - a like-named HTML file containing a diff report so you can see what was done

Here's a summary of the change(s):

admin - made user/admin mode switch confirmation optional

include/exifReader.inc -- added support for SUBJECTAREA tag; fixed COMMENT and WHITEBALANCE/WHITE_BALANCE support to match Exif spec (and actual camera data ).

include/exif_php.inc -- Normalized support for *all* Exif tags: Provide clear text for them all, display all tags except for user-defined "ignore" set. Display (renamed) tags in alphabetical order. Fix DB bug -- add slashes to stored filenames.

displayimage -- make use of above info. Make upload-user/IP display optional (we have users who do not want their name and userid displayed for every viewer of every image!)

lang/*, sql/* -- configuration support for all of the above

Hope this all makes sense! Feel free to get in touch w/ any questions.

[kegobeer]

Regarding user/IP - only admins see the IP addresses.  Your modification stops the Coppermine admin from seeing the user's IP?

[MrPete]

Regarding user/IP - only admins see the IP addresses.  Your modification stops the Coppermine admin from seeing the user's IP?

Y'got me there ... THANK YOU! (I missed that because we have no interest in seeing any of that since our users are known...).

OK, I've fixed it now Admins always see everything; the option only controls whether normal users see username who uploaded a picture. See attached zip update. The lang/english-1.15.php file in this zip is now newer than the copy I uploaded for the safemode fix.

I now have two related questions:

1) Why would the userid and IP of the one uploaded a photo be listed in with the *album* name rather than the *file* name??? I do not understand the logic there.

2) In my experience, the two IP addresses listed are identical. When would they be different?

[Joachim Müller]

2) In my experience, the two IP addresses listed are identical. When would they be different?

I'm not fully sure, as I never pay attention to IP addresses - with dynamic IP addresses and address spoofing there's little point, but users like to see them anyway, it gives them a feeling of power - some think they could actually ban user or track them using IP addresses (which doesn't work in most cases). The reason for two IP addresses is imo only there if users are behind a proxy, sometimes the proxy address and the end user IP shine through differently, but basically you're right: I suggest we drop the two of them, or add a switch and only display two if they differ.

Joachim

[Aditya Mooley]

admin - made user/admin mode switch confirmation optional

Cannot add as this is a feature and we are in feature freeze. Can be considered for 1.5

include/exifReader.inc -- added support for SUBJECTAREA tag; fixed COMMENT and WHITEBALANCE/WHITE_BALANCE support to match Exif spec (and actual camera data Smiley).

include/exif_php.inc -- Normalized support for *all* Exif tags: Provide clear text for them all, display all tags except for user-defined "ignore" set. Display (renamed) tags in alphabetical order. Fix DB bug -- add slashes to stored filenames.

CPG 1.4 has a new EXIF library so these modifications do not apply.

OK, I've fixed it now Admins always see everything; the option only controls whether normal users see username who uploaded a picture.

Again a new feature. Can be added to 1.5

[Joachim Müller]

OK, moving this thread from "CPG 1.3 Testing/Bugs" to "Feature requests  |  Scheduled for cpg1.5.x" then.

Joachim

[Joachim Müller]

Hm, this thread is very old, most of it doesn't apply or has already been done. Moving from "Scheduled for cpg1.5.x" to the feature requests board. Not sure though if it needs further looking into - in fact, it deals with many different items and therefor is hard to track.