Use of ecards_more_pic_target configuration var Use of ecards_more_pic_target configuration var
 

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Main Menu

Use of ecards_more_pic_target configuration var

Started by ovirt, June 03, 2005, 12:14:52 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

ovirt

We're another victim of the "images not displayed in ecard" issue which is tied in with the "Target address for the 'See more pictures' link in e-cards"/ecards_more_pic_target configuration setting.

I see that the docs have now finally been updated to say that this configuration setting must be set to the base url of the coppermine gallery. We consider this an unfortunate choice and would have preferred an additional configuration setting introduced rather than see this item abused in a way it's author evidently didn't intend. As a consequence the displayed configuration text for this item is terribly misleading and I suppose would be awkward to change because of the language/translation issue.

Having said that I have to apologise for not being able to offer a solution to achieve that as I'm just not sufficiently familiar with the inner workings of coppermine and it would simply take me far longer than the time I could afford to put towards it. Perhaps one of the development team would consider reviewing this situation for an upcoming release? That is, to introduce a separate configuration item such as:. gallery_url, etc.

Best wishes

kegobeer

Quote from: ovirt on June 03, 2005, 12:14:52 PM
We're another victim of the "images not displayed in ecard" issue which is tied in with the "Target address for the 'See more pictures' link in e-cards"/ecards_more_pic_target configuration setting.

I see that the docs have now finally been updated to say that this configuration setting must be set to the base url of the coppermine gallery. We consider this an unfortunate choice and would have preferred an additional configuration setting introduced rather than see this item abused in a way it's author evidently didn't intend. As a consequence the displayed configuration text for this item is terribly misleading and I suppose would be awkward to change because of the language/translation issue.

Having said that I have to apologise for not being able to offer a solution to achieve that as I'm just not sufficiently familiar with the inner workings of coppermine and it would simply take me far longer than the time I could afford to put towards it. Perhaps one of the development team would consider reviewing this situation for an upcoming release? That is, to introduce a separate configuration item such as:. gallery_url, etc.

Best wishes

"We consider this an unfortunate choice"?  Abused?  What are you talking about?  Gregory used this variable for more options than just the ecard system.  This variable is correctly set during the installation process, so if the end user changes it without first consulting the documentation to see what it does, the results are solely the responsibility of that end user.  Coders have never complained or had problems using this variable in the mods/hacks, so obviously it's not an issue with them.  If you don't like the text displayed on the config page, open up your language file, search for the phrase, and change it.  If you had taken the time to look at the 1.4 beta version, you would have seen a new variable in the init.inc.php file that is more "user friendly" for coders to use, but the ecards_more_pic_target variable is still there.

The devs have been working on this project ever since Gregory "retired", and we've been in contact with him since we took over the project.  I think we are in a much better position to determine if anything has been "abused."
Do not send me a private message unless I ask for one.  Make your post public so everyone can benefit.

There are no stupid questions
But there are a LOT of inquisitive idiots

Joachim Müller

there are many postings on this board that explain how you can modify the "more pics" link within ecards without "abusing" the "target addres for ecards" setting.

ovirt

You've both missed the point of my comment.

It is quite apparent that the original intention of this configuration item is different to what it is now used for (regardless of whether that was perpetrated by the original author). If you don't thnk that's that case then try taking off your developer's hat for a moment, clear your mind of any preconceptions you have about how things are (i.e. put yourself in the position of a new user). Now look at:

1 - the naming used: "ecards_more_pic_target"
2 - the comment in the configuration screen: "'Target address for the 'See more pictures' link in e-cards"
3 - the (pre-1.3.3) documentation: "This is the URL where a user will be directed when he will click on the "See more pictures" link in an e-card. This should normally be the URL for your gallery but it may be the URL of another page of your site."

It all says "This is a link back to the hosting site", not "This is the base URL of the coppermine gallery".

That's how the author of the site in question was attempting to use it (and thought that she could) and I agree that it's a desirable feature. From the number of questions you get about it perhaps many of the other users would like to be able to use it that way, too.

Is it a huge amount of effort to introduce a new configuration item to provide the base URL info? Or is that's what's happening with 1.4?

Best wishes

Joachim Müller

as suggested before: has been renamed in cpg1.4.x. You're welcome to come up with actual code contributions, i.e. cleaning up the code. Also posted above: it has been the original author who changed the var into something else than the name suggests.