Invalid "id" attribute values in <input> tags in search.php

[kaptainkory]

The characters [ and ] are not allowed in id values.

In search.php, FIND (line 78):

Code Select Expand

                                                <td><input type="checkbox" name="params[title]" id="params[title]" class="checkbox" checked="checked" /><label for="params[title]" class="clickable_option">{$lang_adv_opts['title']}</label></td>

FIND (line 82):

Code Select Expand

                                                <td><input type="checkbox" name="params[caption]" id="params[caption]" class="checkbox" checked="checked" /><label for="params[caption]" class="clickable_option">{$lang_adv_opts['caption']}</label></td>

FIND (line 86):

Code Select Expand

                                                <td><input type="checkbox" name="params[keywords]" id="params[keywords]" class="checkbox" checked="checked" /><label for="params[keywords]" class="clickable_option">{$lang_adv_opts['keywords']}</label></td>

FIND (line 91):

Code Select Expand

                                                <td><input type="checkbox" name="params[owner_name]" id="params[owner_name]" class="checkbox" /><label for="params[owner_name]" class="clickable_option">{$lang_adv_opts['owner_name']}</label></td>

FIND (line 98):

Code Select Expand

                                                <td><input type="checkbox" name="params[filename]" id="params[filename]" class="checkbox" /><label for="params[filename]" class="clickable_option">{$lang_adv_opts['filename']}</label></td>


Not knowing the code too well, I'll not suggest a fix at the risk of breaking something else.

Thanks.

[donnoman]

can another dev look into this, they also litter upload.php.

[Joachim Müller]

committed a fix for the square brackets issue in search.php (files modified: search.php, thumbnails.php, include/search.inc.php). Please confirm fix.

Joachim

Please start a new thread for the issues in upload.php, as they require a different fix.