Forbidden characters not getting replaced

[Abbas Ali]

In the function replace_forbidden in functions.inc.php the code

Code Select Expand


preg_match_all("#$mb_utf8_regex".'|[\x00-\x7F]#', $chars, $forbidden_chars);


gives a 2D array in $forbidden_chars and hence

Code Select Expand


str_replace($forbidden_chars, '_', $str);


was not working and forbidden chars were not being replaced with "_"

Modified the code accordingly and committed to devel version. Please confirm.

[Edit]
Added space and ampersand for forbiden_fname_char in insert query (basic.sql) and added an update query for the same in update.sql
[/Edit]

[Joachim Müller]

haven't checked, but this sounds like very good work.

[artistsinhawaii]

Shouldn't this be marked "fixed" as well?

[Joachim Müller]

needs confirmation before being marked as fixed - Abbas requested a dev confirm his fix.

[artistsinhawaii]

Ah!  sorry,
I thought this was tied in to the other forbidden character issues that were just fixed.


Dennis

[Abbas Ali]

Yes this was partly tied to the Spaces in filenames issue issue which has been fixed now.

Marking this thread as fix.