Completely lost and confused on theme upgrading

[nikole]

I don't understand things it's telling me to do on this page.

http://coppermine-gallery.net/demo/cpg14x/docs/theme/index.html
I've got the template.html right I think. There were no errors in my code.

First the style.css. Here's my code after doing everything it told me to do.

Code Select Expand

body {
        background: url("images/bg.gif");
        background-color: #000000;
        font-family: verdana;
     font-size: 8pt;
        color: #000000;
        margin: 0px;
}

table,tr,td,table table {
     font-size: 8pt;
}

h1{
        font-weight: normal;
        font-size: 9pt;
        font-family: verdana;
        text-decoration: none;
        color: #404040;
        margin: 2px;
}

h2 {
        background-image : url(images/box_left_icon.gif);
        background-repeat : no-repeat;
        background-position : left;
        padding-left : 18px;
        font-size: 9pt;
        font-family: verdana;
        margin: 0px;
}

h3 {
        font-weight: normal;
        font-size: 9pt;
        font-family: verdana;
        margin: 2px;
}

p {
        font-size: 8pt;
        font-family: verdana;
        margin: 2px 0px;
}

ul {
        margin-left: 5px;
        padding: 0px;
}

li {
        margin-left: 8pt;
        margin-top: 4px;
        margin-bottom: 4px;
        padding: 0px;
        list-style-position: outside;
        list-style-type: disc;
}

.textinput {
        font-family: verdana;
        font-size: 8pt;
        border: 1px solid #FFFFFF;
        padding-right: 3px;
        padding-left: 3px;
}

.listbox {
        font-family: verdana;
        font-size: 8pt;
        border: 1px solid #FFFFFF;
        vertical-align : middle;
}

.button {
        font-family: verdana;
        font-size: 8pt;
        border: 1px solid #FFFFFF;
        background: #000000;
}

.comment_button {
        font-family: verdana;
        font-size: 8pt;
        border: 1px solid #FFFFFF;
        background: #000000;
}

.radio {
        font-family: verdana;
        font-size: 8pt;
        vertical-align : middle;
}

.checkbox {
        font-family: verdana;
        font-size: 8pt;
        vertical-align : middle;
}

a {
        color: #747474;
        text-decoration: none;
}

a:hover {
        color: #747474;
        text-decoration: underline;
}

bblink a {
        color: #747474;
        text-decoration: none;
}

bblink a:hover {
        color: #747474;
        text-decoration: underline;
}

.maintable {
        border: 2px solid #FFFFFF;
        background-color: #FFF;
        margin-top: 1px;
        margin-bottom: 1px;
}

.tableh1 {
        font-family: verdana;
        font-size: 8pt;
        background : #000000;
        color: #FFFFFF;
        padding-top: 3px;
        padding-right: 8pt;
        padding-bottom: 3px;
        padding-left: 8pt;
}

.tableh1_compact {
        font-family: verdana;
        font-size: 8pt;
        background : #000000;
        color: #FFFFFF;
        padding-top: 2px;
        padding-right: 5px;
        padding-bottom: 2px;
        padding-left: 5px;
}

.tableh2 {
        background: #FFFFFF;
        color : #000000;
        padding-top: 3px;
        padding-right: 8pt;
        padding-bottom: 3px;
        padding-left: 8pt;
}

.tableh2_compact {
        background: #FFFFFF;
        color : #000000;
        padding-top: 2px;
        padding-right: 5px;
        padding-bottom: 2px;
        padding-left: 5px;
}

.tableb {
        background: #FFFFFF;
        padding-top: 3px;
        padding-right: 8pt;
        padding-bottom: 3px;
        padding-left: 8pt;
}

.tableb_compact {
        background: #000000 ;
        padding-top: 2px;
        padding-right: 5px;
        padding-bottom: 2px;
        padding-left: 5px;
}

.tablef {
        background: #FFFFFF;
        padding-top: 8pt;
        padding-right: 8pt;
        padding-bottom: 8pt;
        padding-left: 8pt;
}

.album_stat {
        font-size: 8pt;
        margin: 5px 0px;
}

.thumb_title {
        font-weight : bold;
        font-size: 8pt;
        padding: 2px;
        display : block;
}

.thumb_caption {
        font-size: 8pt;
        padding: 1px;
        display : block;
}

.thumb_caption a {
        text-decoration: none;
        color: #747474;
}


.thumb_num_comments {
        font-weight: normal;
        font-size: 8pt;
        padding: 2px;
        font-style : italic;
        display : block;
}

.user_thumb_infobox {
        margin-top: 1px;
        margin-bottom: 1px;
}

.user_thumb_infobox th {
        font-weight : bold;
        font-size: 8pt;
        margin-top: 1px;
        margin-bottom: 1px;
        text-align : center;
}

.user_thumb_infobox td {
        font-size: 8pt;
        margin-top: 1px;
        margin-bottom: 1px;
        text-align : center;
}

.user_thumb_infobox a {
        text-decoration: none;
        color: #000000;
}

.user_thumb_infobox a:hover {
        color: #000000;
        text-decoration: underline;
}

.sortorder_cell {
        background : #000000;
        color: #FFFFFF;
        padding: 0px;
        margin: 0px;
}

.sortorder_options {
        font-family: verdana;
        background : #000000;
        color: #FFFFFF;
        padding: 0px;
        margin: 0px;
        font-weight: normal;
        font-size: 8pt;
        white-space: nowrap;
}

.navmenu {
        font-family: verdana;
        font-size: 8pt;
        width: 610;
        color: #FFFFFF;
        font-weight: bold;
        background : #000000;
        border-style: none;
}

.navmenu img {
}

.navmenu a {
        text-decoration: none;
        color: #FFFFFF;
}

.navmenu a:hover {
        background : #000000 ;
        text-decoration: none;
        color:         #000000;
}

.admin_menu_thumb {
        font-family: verdana;
        font-size: 8pt;
        border: 1px solid #ccd7e0;
        color: #000000;
        font-weight: bold;
        width: 85px;
}

.admin_menu_thumb a {
        color: #000000;
        text-decoration: none;
        display: block;
        position: relative;
        padding-top: 5px;
        padding-bottom: 5px;
        padding-left: 5px;
        padding-right: 5px;
}


.admin_menu_thumb a:hover {
        color: #000000;
        text-decoration: underline;
}

.admin_menu {
        background: #C8C8C8;
        font-family: verdana;
        font-size: 8pt;
}

.admin_menu a {
        color: #000000;
        text-decoration: none;
        display: block;
        position: relative;
}

.admin_menu a:hover {
        color: #000000;
        text-decoration: underline;
}

.comment_date{
        color : #5F5F5F;
        font-size: 90%;
        vertical-align : middle;
}

.image {
        border: 2px solid #FFFFFF;
}

.thumbnails {
        background: #000000 ;
        padding: 5px;
}

.footer {
        font-size: 8pt;
}

.footer a {
        text-decoration: none;
        color: #000000;
}

.footer a:hover {
        color: #000000;
        text-decoration: underline;
}

.statlink {
        color: #FFFFFF;
}

.statlink a {
        text-decoration: none;
        color: #FFFFFF;
}

.statlink a:hover {
        color: #FFFFFF;
        text-decoration: underline;
}

.alblink a {
        text-decoration: none;
        color: #747474;
}

.alblink a:hover {
        color: #747474;
        text-decoration: underline;
}

.catlink {
        display: block;
        margin-bottom: 2px;
}

.catlink a {
        text-decoration: none;
        color: #747474;
}

.catlink a:hover {
        color: #747474;
        text-decoration: underline;
}

.topmenu {
        background: #000000;
        border: 2px solid #FFFFFF;
        font-family: verdana;
        font-size: 8pt;
}

.topmenu a {
        color : #747474;
        text-decoration : none;
}

.topmenu a:hover  {
        color : #747474;
        text-decoration : underline;
}

.img_caption_table {
        border: none;
        background-color: #FFFFFF;
        width : 100%;
        margin : 0px;
}

.img_caption_table th {
        background: #000000;
        font-size: 8pt;
        color : #000000;
        padding-top: 4px;
        padding-right: 8pt;
        padding-bottom: 4px;
        padding-left: 8pt;
        border-top : 1px solid #FFFFFF;
}

.img_caption_table td {
        background: #000000 ;
        padding-top: 6px;
        padding-right: 8pt;
        padding-bottom: 6px;
        padding-left: 8pt;
        border-top : 1px solid #FFFFFF;
}


When I try validating it gives me these errors.


Error Line 1 column 0: character "b" not allowed in prolog.
body {


Error Line 16 column 8: character "f" not allowed in prolog.
        font-size: 9pt;


Error Line 27 column 8: character "p" not allowed in prolog.
        padding-left : 18px;


Error Line 42 column 8: character "f" not allowed in prolog.
        font-family: verdana;


Error Line 57 column 8: character "l" not allowed in prolog.
        list-style-type: disc;


Error Line 71 column 8: character "b" not allowed in prolog.
        border: 1px solid #FFFFFF;


Error Line 84 column 8: character "f" not allowed in prolog.
        font-size: 8pt;


Error Line 98 column 8: character "v" not allowed in prolog.
        vertical-align : middle;


Error Line 117 column 8: character "c" not allowed in prolog.
        color: #747474;


Error Line 131 column 8: this is not an SGML document.
        background : #000000;


Error Line 131 column 8: cannot continue because of previous errors.
        background : #000000;


And for theme.php upgrading I understand absolutly nothing it says on that page other than steps 1-3.

[nikole]

In the style.css code I've got the vanity code at the end too. Forgot to put that in in previous post.

Code Select Expand

#vanity a {
        display:block;
        width:57px;
        height:20px;
        margin: 3px 20px;
}
#vanity img {border:0}
#v_php {float:left;background-image:url(../../images/powered-php.gif);}
#v_php:hover {background-image:url(../../images/h_powered-php.gif);}
#v_mysql {float:left;background-image:url(../../images/powered-mysql.gif);}
#v_mysql:hover  {background-image:url(../../images/h_powered-mysql.gif);}
#v_xhtml {float:right;background-image:url(../../images/valid-xhtml10.gif);}
#v_xhtml:hover {background-image:url(../../images/h_valid-xhtml10.gif);}
#v_css {float:right;background-image:url(../../images/valid-css.gif);}
#v_css:hover{background-image:url(../../images/h_valid-css.gif);}

[Joachim Müller]

where's the link to your coppermine gallery? How should we advice if you don't post it?

[nikole]

Whoops!

http://www.harsh-light.org/adenisof/gallery/

[Joachim Müller]

Your custom theme doesn't work, the tokens {CUSTOM_HEADER}, {SYS_MENU}, {SUB_MENU}, {CUSTOM_FOOTER} and {VANITY} shine through. There's no need to validate the stylesheet yet, you should worry about that later. First, fix the hard errors in your custom theme.

[nikole]

I know those come through but that's what the upgrading thing told me to do but I'll take them out anyway I guess.

[Joachim Müller]

Fix them first anyway before taking care of the stylesheet. The stylesheet is only cosmetics, validating is only optional.

[nikole]

Okay I took them out of the code.

[Joachim Müller]

You mustn't remove the tokens, put them back in and make sure they are parsed as suggested.

[nikole]

But  I don't know where to put them. When I put them in the places the tutorial tells me to they show through.

[Joachim Müller]

you've messed with theme.php incorrectly then, or you haven't updated your cpg1.3.x theme.php as suggested. Put the tokens back into template.html. Then store a backup of your current theme.php. Next, copy the content of themes/classic/theme.php into themes/yourtheme/theme.php (overwriting everything in it). Check that the tokens are parsed then. Next step: edit theme.php if you're not happy with it by copying bits from themes/sample/theme.php that you want to see changed. This is all in the theme upgrade guide, please review it more carefully.

[nikole]

Okay I got it now. I did read that guide though. You explained it easier. The guide just confused me.