Table header should not be used for areas the size of paragraphs or lists Table header should not be used for areas the size of paragraphs or lists
 

News:

CPG Release 1.6.27
change DB IP storage fields to accommodate IPv6 addresses
remove use of E_STRICT (PHP 8.4 deprecated)
update README to reflect new website
align code with new .com CPG website
correct deprecation in captcha

Main Menu

Table header should not be used for areas the size of paragraphs or lists

Started by silly_walk, August 31, 2006, 08:59:13 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

silly_walk

The tags that include "tableh" and its variants are not only used for headers (Sort my Albums, as an example), which makes it hard to skin properly, because the headers look great until you run into a part of the gallery where there is not actually a header but that uses the header tag (the screen where you place uploaded pics is another example). These areas should be re-I.D.ed / re-classed.

Joachim Müller

Valid request. Could you come up with some code examples, where the tablehX classes are being used in places they're not suppossed to?

silly_walk

From upload.php:
    // Create image tag and echo it to the output buffer.
    echo "<tr><td class=\"tableh2\"><img class=\"image\" src=\"".$path_to_preview."\"  /></td>";

    // Echo instructions.
    echo "<td class=\"tableh2\">{$lang_upload_php['picture']} - {$file_set[0]}<br /><br />{$lang_upload_php['place_instr_1']}<br /><br />";


From groupmgr.php:
    while ($group = mysql_fetch_array($result)) {
        $group['group_name'] = $group['group_name'];
        $row_counter++;
        if ($row_counter == 1 ) {$table_background = 'tableb';}else{$table_background = 'tableh2';$row_counter = 0;}