Modify space between the two frames where picture is embedded

[Bonanza]

Hi all,

I am using the project vii theme. Where (in which file/s) could I modify the space between the two frames (the thin black lines) where the picture (not the thumbnail) is embedded in?

Thanks for help!
Bonanza

[Joachim Müller]

Not sure what you mean. The theme "project vii" doesn't use frames. Post a link to your gallery for a start and attach a screenshot (using "addtional options" when composing your message) with the section you want to see modified highlighted.

[Bonanza]

Sorry for the delay, but I wanted to update my galery to version 1.4.12 first to avoid discussing about problems which may have been fixed in the current version of coppermine.

Nevertheless I furthermore have a weird behaviour of the frame that is around the picture. The distance of the frame is not equal on the left and the right side (using Firefox), with Internetexplorer the distance is not equal on the top and the bottom line.
Weird is that everything is perfectly centered when I am logged in as admin.
To avoid misunderstandings which problem I have I attached two pictures: the left one with the layout problem as a normal user visiting my website sees it and the right picture if I am logged in as admin and without the problem.

Btw. I have the same effect if I switch to an unmodified standard theme (I am using a modified project_vii theme)
If I check the layout on your demosite everything is fine too.

Any help in isolating the cause for this behaviour is greatly appreciated.

B.r.
Bonanza

If you want to see this live in my gallery the url is http://www.volker-ackermann.com/gallery/index.php

[Joachim Müller]

Please zip your custom theme and attach it to your posting as well, so we can see what you actually changed.

[Bonanza]

I have attached my customized theme, but please keep in mind that the problem exists with unmodified themes too.
B.r.
Bonanza

[Joachim Müller]

Unable to replicate this issue on my testbed, although I can confirm that this happens on your site, so I guess this comes from an outdated version not fully upgraded, as you appear to have upgraded at some stage from cpg1.4.3 to cpg1.4.12. Please review versioncheck.php and post your results.

[Sami]

copy this to your theme.php

Code Select Expand


$template_display_media = <<<EOT
        <tr>
                <td align="center" class="display_media" nowrap="nowrap">
                        <table cellspacing="2" cellpadding="0" class="imageborder">
                                <tr>
                                        <td align="center">{IMAGE}</td>
                                </tr>
                        </table>
                </td></tr>
                <tr><td>
                                                <table width="100%" cellspacing="2" cellpadding="0" class="tableb">
                                <tr>
                                        <td align="center">

                                                {ADMIN_MENU}
                                        </td>
                                </tr>
                        </table>





<!-- BEGIN img_desc -->
                        <table cellpadding="0" cellspacing="0" class="tableb" width="100%">
<!-- BEGIN title -->
                                <tr>
                                        <td class="tableb"><center><b>
                                                {TITLE}
                                        </b></center></td>
                                </tr>
<!-- END title -->
<!-- BEGIN caption -->
                                <tr>
                                        <td class="tableb"><center>
                                                {CAPTION}
                                        </center></td>
                                </tr>
<!-- END caption -->
                        </table>
<!-- END img_desc -->
                </td>
        </tr>

EOT;

and let us know ....
I see that there was an empty line between <td> and <img> tag (image will go to {IMAGE} placeholder) and that cause the problem

[Bonanza]

Hello Sami,

I tried inserting your code in theme.php but unfortunately it did not fix the layout problem. If I am logged in as admin everything is fine.
Tried different unchanged themes, same effect.

B.r.
Bonanza

[Bonanza]

Unable to replicate this issue on my testbed, although I can confirm that this happens on your site, so I guess this comes from an outdated version not fully upgraded, as you appear to have upgraded at some stage from cpg1.4.3 to cpg1.4.12. Please review versioncheck.php and post your results.

Hello GauGau,

versioncheck as requested:

[Sami]

Empty line is still there !
Let's try this
put a <br /> after {IMAGE} so your code should be look like this

Code Select Expand


$template_display_media = <<<EOT
        <tr>
                <td align="center" class="display_media" nowrap="nowrap">
                        <table cellspacing="2" cellpadding="0" class="imageborder">
                                <tr>
                                        <td align="center">{IMAGE}<br /></td>
                                </tr>
                        </table>
                </td></tr>
                <tr><td>
                                                <table width="100%" cellspacing="2" cellpadding="0" class="tableb">
                                <tr>
                                        <td align="center">

                                                {ADMIN_MENU}
                                        </td>
                                </tr>
                        </table>





<!-- BEGIN img_desc -->
                        <table cellpadding="0" cellspacing="0" class="tableb" width="100%">
<!-- BEGIN title -->
                                <tr>
                                        <td class="tableb"><center><b>
                                                {TITLE}
                                        </b></center></td>
                                </tr>
<!-- END title -->
<!-- BEGIN caption -->
                                <tr>
                                        <td class="tableb"><center>
                                                {CAPTION}
                                        </center></td>
                                </tr>
<!-- END caption -->
                        </table>
<!-- END img_desc -->
                </td>
        </tr>

EOT;

Hope it works ...

[Bonanza]

Hello Sami,

I tested it asap, something has changed in the layout, but now the picture is too much to the left (in Firefox) and the bottom line is to wide (and much to wide in IE).

You can see it on my website: http://www.volker-ackermann.com/gallery/index.php

B.r.
Volker

[Sami]

Okay remove that <br /> from code

As version check shows ,there isn't any change on themes.inc.php But I don't know why you don't have the harcoded <br /> on {gallery-root}\include\themes.inc.php on line #2125

Would you check that line for me and tell me what exactly do you have there (please check the files on server not on your local machine)?

[Bonanza]

Hello Sami:

Line 2125 of themes.inc.php is:

$pic_html .= "<img src=\"" . $picture_url . "\" class=\"image\" border=\"0\" alt=\"{$lang_display_image_php['view_fs']}\" /><br />";

B.r.
Bonanza

[Sami]

And what do you have on line 2128?
also make sure that you didn't have theme_html_picture() function on your theme.php

[Bonanza]

Hello Sami,

line 2128 is:
$pic_html = "<img src=\"" . $picture_url . "\" {$image_size['geom']} class=\"image\" border=\"0\" alt=\"\" /><br />\n";

There is no theme_html_picture() function in my theme.php


B.r.
Bonanza

[Bonanza]

I found what causes the different layout for admin and guest users, it is the Full-Size Photos Access Control v1.2 Plugin, as soon as I allow the guest users to see the photos in full size (which I do not want of course) the differences are gone and the layout is perfect.
If I disallow guest users to see the photo in full size (which makes no sense on my website) the layout error is there.

I will now try the a newer version of the Full-Size Photos Access Control and report if the error is fixed there.

[Bonanza]

I could reproduce the problem with V 1.4 of the Full-Size Photos Access Control plugin too. On my PC there is no difference if I use my modified or unmodified theme, the error persists. Could it be a general error with this plugin?

[Sami]

Then change line #124 of codebase.php from

Code Select Expand


$cpicdata['html'] = strip_tags($cpicdata['html'],'<img>');

to this

Code Select Expand


$cpicdata['html'] = strip_tags($cpicdata['html'],"<img><br>");


this code change is for version 1.2
If this works I'll add it to the plugin's thread for others

[Bonanza]

Hello Sami,

works perfect!! I have tested it with version 1.4 of the plugin (line 210).

Thanks a lot for your support and spending your free time to help me!

B.r.
Volker

[Joachim Müller]

Code Select Expand

<br>should actually be

Code Select Expand

<br />