[Done]: Try to improve the performance of random pictures show!!

[jokera]

in CPG 1.4.18 functions.inc.php
Line1229:

Code Select Expand


$query = "SELECT $select_columns FROM {$CONFIG['TABLE_PICTURES']} WHERE approved = 'YES' $META_ALBUM_SET ORDER BY RAND() LIMIT $limit2";
$result = cpg_db_query($query);

Change to:

Code Select Expand


$queryrndlimit = "SELECT `pid` FROM {$CONFIG['TABLE_PICTURES']} WHERE approved = 'YES' $META_ALBUM_SET ORDER BY RAND() LIMIT $limit2";
$rndlimitresult = cpg_db_query($queryrndlimit);
$pidstring="(0";
while($pidtemp=mysql_fetch_array($rndlimitresult)){
    $pidstring.=",".$pidtemp['pid'];
}
$pidstring.=")";
$query = "SELECT $select_columns FROM {$CONFIG['TABLE_PICTURES']} WHERE `pid` in $pidstring";
$result = cpg_db_query($query);


In my site:(Total 566xx pictures)
Original method : 12~14 seconds
New method : 0.23~0.4 seconds

[jokera]

Sorry..I write the wrong title 
It should be "of" not "or" 

[Joachim Müller]

Not related to photography, moving accordingly. In the future, use the proper sub-board!

[Nibbler]

We should add this to 1.5. It will help with the 'Got error 28 from table handler' issue too.