Download in forum not working?

[olli80]

Hi there,

everytime i click on a download link in this forum it just give me a index.php for downloading.

I´m registered and loged in!

Is it a problem with the forum or me?

[Αndré]

I also noticed that behavior with the latest Firefox release. The content of the file is correct, but the file name is always index.php. It doesn't happen with e.g. Chrome, at least for me. I don't know if it's a general issue with Firefox, SMF2 or just the combination of (my) Firefox and our board.

Maybe someone else can report their experiences, so we can post a bug report if necessary.

[lurkalot]

It's a SMF issue.  Has this been resolved now?  If not there's some info regarding the problem here, http://www.simplemachines.org/community/index.php?topic=451766.0  it also says what file to edit to resolve it.

[Αndré]

Still happens for me, e.g. when I try to download a zip file from the plugin contributions board.

[lurkalot]

Still happens for me, e.g. when I try to download a zip file from the plugin contributions board.

Andre, I don't have server access, so I'm waiting for an official patch that can be installed through the package manager to solve this issue.   There is one patch available ATM, but waiting for feedback on it to make sure it covers all types of attachment.

[Αndré]

I assume you're talking about that patch: http://dev.simplemachines.org/mantis/view.php?id=4825

Unlike described in the instructions you have to apply that patch to the file Sources/Display.php (at least that's the only place I found the code part). I'll apply the patch soon and will test as thorough as possible.

[Αndré]

Test file attached.

Update: Doesn't work with file names with spaces (as expected, as they removed the required quotes). I'll now try to fix that issue for our board. If we have a working fix, we can provide it to the SMF team. Do you have an account on their boards, lurkalot?

[lurkalot]

Thanks Andre, hopefully sorted then. 

Cheers. 

[Αndré]

I just updated my previous post.

[lurkalot]

I think this has been mentioned before in another thread, I'll see if I can find it.

[lurkalot]

This is the tread where the patch with install via package manager is posted.  I'm sure it mentions the quotes problem too. http://www.simplemachines.org/community/index.php?topic=454734.0

[Αndré]

I haven't read that thread yet, but think I fixed it on my own. Needs some more testing, but removing the whole Firefox case (and using the default method) seems to work as expected for file names with and without spaces. Will test non-latin characters now.

[Αndré]

Test file with spaces and non-latin characters attached.

Update: the UTF-8 characters get encoded. Not very beautiful, but as the majority of our files contain just alphanumeric latin characters a workaround I can live with, until a real fix is provided by the SMF team.

[lurkalot]

That's fantastic Andre, as long as it works that's the main thing.  I'll keep following the progress over at SMF.

Thanks again. 

[Αndré]

We're now using the Opera header, as it works as expected as far as I can judge.