Most Viewed Issues

[Llama8668]

I've upgraded my galleries to 1.5.6 (from an older 1.4 version). This appears to have gone smoothly but I'm seeing some errors when it comes to the most viewed functionality.

When viewing a gallery and sorting by most viewed and then trying to view an image the below errors are seen (these are two instances from separate galleries). It doesn't appear to effect all albums. I have test added a new album to one of the galleries and the error is seen.

I'm also seeing that when the same method is used (open album, switch to most viewed and then try and view an image) on some albums the wrong image is displayed (so you get a different image to the thumbnail when you click on it.

Any suggestions on what might be causing the issue and how to resolve it?

Code Select Expand

While executing query 'SELECT r.pid, r.aid, filepath, filename, url_prefix, pwidth, pheight, filesize, ctime, r.title, r.keywords, r.votes, pic_rating, hits, caption, r.owner_id, pic_raw_ip, pic_hdr_ip
                FROM cpg1411_pictures AS r
                INNER JOIN cpg1411_albums AS a ON a.aid = r.aid
                WHERE (r.aid = 834)
                AND approved = 'YES'
                AND hits > 0
                ORDER BY hits ASC, pid DESC
                 LIMIT 0 ,-2818' in include/functions.inc.php on line 1593

mySQL error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-2818' at line 8


File: include/functions.inc.php - Line: 258

Code Select Expand

While executing query 'SELECT r.pid, r.aid, filepath, filename, url_prefix, pwidth, pheight, filesize, ctime, r.title, r.keywords, r.votes, pic_rating, hits, caption, r.owner_id, pic_raw_ip, pic_hdr_ip
                FROM cpg1410_pictures AS r
                INNER JOIN cpg1410_albums AS a ON a.aid = r.aid
                WHERE (r.aid = 205)
                AND approved = 'YES'
                AND hits > 0
                ORDER BY hits ASC, pid DESC
                 LIMIT 0 ,-2' in include/functions.inc.php on line 1593

mySQL error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-2' at line 8

[Joachim Müller]

Board rules / Forum policies: Post Links

[Llama8668]

The error message is best seen at http://www.neighbourssource.com/Gallery/. To replicate choose a recent gallery (for example http://www.neighbourssource.com/Gallery/thumbnails.php?album=826). Sort by most viewed (http://www.neighbourssource.com/Gallery/thumbnails.php?album=topn&cat=-826). Try selecting any of the images (http://www.neighbourssource.com/Gallery/displayimage.php?album=topn&cat=-826&pid=54416#top_display_media) and you get a critical error returned (debug mode is currently only on for admins but I can enable it for all users if needed.

When you use the gallery most viewed link (when on the gallery index) images appear to load okay (http://www.neighbourssource.com/Gallery/displayimage.php?album=topn&cat=0&pid=2219#top_display_media). I am using a custom theme which I haven't updated since the upgrade though switching to the default curve theme doesn't resolve the issue (so it doesn't appear to be a problem with outdated links).

The image switching problem can be seen at http://www.sarahchalkefan.com/Gallery/. When you select some of the galleries (for example http://www.sarahchalkefan.com/Gallery/thumbnails.php?album=328), sort by most viewed (http://www.sarahchalkefan.com/Gallery/thumbnails.php?album=topn&cat=-328) and then select an image you get a different one to the thumbnail. On the http://www.sarahchalkefan.com/Gallery/thumbnails.php?album=topn&cat=-328 page if you select the first thumbnail this issue is seen. Selecting the last image delivers a The selected album/file does not exist! error.

[Αndré]

Already fixed in svn.

[Joachim Müller]

@André: maybe it's time to package a new maintenance release - after all you have fixed a lot of minor issues since the release of cpg1.5.6, so a maintenance release would be warranted.

[phill104]

I was thinking the same this morning. The changelog is getting quite large now as Andre has been a busy bunny.

Is there anything outstanding that we should fix before the release?

[phill104]

I've just cycled through the bugs board and removed older [MOVED] posts (I hope that is OK to do that Joachim?).

We have quite a few bugs still listed going back quite some time. It would be great if everyone could check through those and update if they have been fixed or not before we release .8.

[Αndré]

Is there anything outstanding that we should fix before the release?

I want to fix/change at least 2 or 3 issues before the release of cpg1.5.8. But I think I'll finish that soon.

[Joachim Müller]

I've just cycled through the bugs board and removed older [MOVED] posts (I hope that is OK to do that Joachim?).

That's fine, thanks. You as an admin can do that using the corresponding maintenance option in SMF.

I want to fix/change at least 2 or 3 issues before the release of cpg1.5.8. But I think I'll finish that soon.

OK, great. Please let us know when you think it's ready.

[Αndré]

Please let us know when you think it's ready.

I solved my big TODOs today. Needs some testing and a new entry to the docs though (see here). I'll have a look at the bugs board tomorrow if there are some show stoppers and then we can package cpg1.5.8. This time we should test the package before we release it, as we had some versioncheck issues last time, as you remember.

[Joachim Müller]

Yes, definitely. But I'd like to figure out the reasons for those versioncheck issues, i.e. I want t o know why some images acted up as far as the hash is concerned.

[Αndré]

I also added some other stuff I wanted to add since months today. I think we can package the next release, if nobody detects some show-stopper.