Possible bug creating hit_stats table

[andresf]

Hello:

My name is Andres and this is my first message in this forum. I want to thank André for his help with some problems I had registering.

I discovered the Coppermine Gallery a while ago and have some experience programming it. I hope I can contribute something to improve this tool.

In this post, I wanted to warn about a possible bug in the sql\schema.sql file. When the "hit_stats" table is created, the `pid` field should be of type INT, according to the documentation, not VARCHAR(100). This can be found on line 196.

Regards

[ron4mac]

Thank you for posting your discovery. Technically, you are correct. But it has been mis-declared like that for over 18 years without issue.

[andresf]

Thanks, ron4mac, for your reply. Indeed, it's not really a "bug" that affects the gallery's functionality.

I realized this when I saw that the "hit_stats" table is possibly the one that grows the most and takes up the most space in the database, and that field ('pid') declared as VARCHAR(100) contributes to it taking up even more space.

[andresf]

Well, it doesn't really take up much more space; the VARCHAR type adjusts the space to the entered data.