[BUG] Extra quote generated in code by line 1028 functions.inc.php

[donnoman]

Extra unmatched quotes found when trying to validate HTML 4.01 for cpg 1.3.2.


Line 188, character 150:
... mb_WMASTM.JPG" class="image" " height="50" border="0" alt="W ...
                                                   ^
Error: an attribute specification must start with a name or name token

I believe I've found the offending piece of code: it's Line 1028 of functions.inc.php

Code Select Expand



$image_size['geom'] = '" height="'.$image_size['height'].'"';



changed line 1028 to:

Code Select Expand


$image_size['geom'] = 'height="'.$image_size['height'].'"';



It appears that the 1.4x codebase already has this fix in it.

[Casper]

Please understand what we consider a bug.  It is something that causes coppermine to fail to work as expected, or fail to work at all, or causes crashes etc.

We know 1.3.2 will not validate, but that does not make this a bug, just an uglyt bit of miscoding that actually causes no problems.

Yes, we are striving to make version 1.4 xhtml 1 transitional compliant, and with a couple of minor exceptions, are already there.

[donnoman]

I did search for this before I posted and I didn't find anything directly related to it being a known issue.

I was just posting the information so that if someone else DID search for it, they would find my post, and know how to fix it themselves.

And they could also be assured that it's already been addressed in the 1.4 codebase. (Because that's what I was concerned about)

But the extra " doesn't belong there. Its a bug.  Maybe not important; but a bug none-the-less.

Further, I put my time where my mouth is. I did the research and proposed a simple fix, and also tested the fix on my server before I posted.

[Joachim Müller]

@donnoman: point taken and noted, but Casper's definition of what we consider a bug is correct. Labelling cosmetical issues a bug will give the software a bad repution that it doesn't deserve imo. There are only very few popular apps that actually are (x)html standards compliant. After all xhtml is a rather new standard, while cpg1.3.x is not developed any further - there won't be new cpg1.3.x releases (unless an actual security flaw is found), that's why there is little point in this argument. However we appreciate your concerns and your willingness to improve coppermine.

Joachim

[donnoman]

@GauGau point taken and noted, perhaps if I had just labeled it [Validation Issue] we wouldn't have had this misunderstanding. IMO if this hadn't already been fixed in the 1.4 codebase, I would think that the devs would still want to know about it and eventually fix it.

[Joachim Müller]

the issue you're reporting has been fixed in the stable branch of the cvs some time ago already, so the cpg1.3.x "codebase" is fixed. It just hasn't made it's way into the latest stable release. There are many file in the stable cvs branch that have minor fixes that are not in any package - we only release if we consider the effort of releasing a new version worth the trouble. Since cpg1.3.x doesn't validate anyway, the glitch you're reporting won't hurt.
Bottom line: the issue you report has been fixed already some time ago.

Joachim