Upload Approval Button Gone

[Doulos]

I am using cpg1.4.4 and have the permissions set so that users can have a private gallery but that uploads must be aprroved. Also, I have config set to email me if an upload is awaiting appoval. 

However, I am having 2 problems:

• 1. Uploads to private galleries don't require appoval.
• 2. There is no "Upload Approval" button.

I have made a test user, made his album visible only to him, uploaded a pic and it still doesn't require admin approval. Nor does the "Upload Approval" button show up.  The only changes I have made were made to only one theme (Hardwired), and that was just adding a couple user menu buttons.  Switching to a different them makes no difference.

[Joachim Müller]

post a link and non-admin test user account with upload privileges.

[Doulos]

www.clanfga.com/FGAGallery/

user: testuser
PW:  testuserpw

[Doulos]

I have a slightly older version running on a different website and the "upload approval" button is present.  All config settings and group permissions are the same.

[Joachim Müller]

well, it appears that you haven't enabled admin approval - the file I uploaded was visible instantly: http://www.clanfga.com/FGAGallery/displayimage.php?pos=-45
Review your groups page settings. If you think that they are correcty, but approval still doesn't work for you, post a screenshot of your groups page (attach it to your posting by using "additional options" when composing your message).

[Doulos]

Here is screenshot of group permissions.

[Joachim Müller]

well, I uploaded to a public album (because you allowed me to do so) - the approval setting for public albums is set to "no" in your setup, so (surprisingly ) my upload was visible instantly. Take a deep breath and review your settings.

[Doulos]

Maybe I didn't make it clear. I am talking about private albums - not public.  Members who make a personal album (whether or not they make the upload private) get the pics posted immediately - without admin approval.  I believe my permissions require personal gallerys to have admin approval.  If I am doing something wrong I would sure like to know what it is. 

[Joachim Müller]

I can confirm that my upload to an album within the personal gallery was visible instantly: http://www.clanfga.com/FGAGallery/displayimage.php?pos=-49
Did you apply any mods?
Upgrade to cpg1.4.4

[Doulos]

No. Did not install any mods.  I guess I'll have to uninstall and intstall it again.  I don't want to have to constantly be checking to see what is being put in private gallerys.  I like the idea of an email when there is content waiting approval.

[Joachim Müller]

upgrade as suggested

[Doulos]

Upgrade?  I am using v 1.4.4. 

[Joachim Müller]

no, you're not. You're using cpg1.4.3.

[Doulos]

hmm, thought I applied the 1.4.4 changes.  Guess not.

[Doulos]

Actually, I did manually apply the "fix" mentioned here:

http://forum.coppermine-gallery.net/index.php?topic=28445.msg131584#msg131584

I am upgrading to the full version of 1.4.4 now.

[Doulos]

Upgrade didn't fix the problem. Still no "upload approval" button and ppl are able to upload and view pics in personal galleries immediately. 

[Joachim Müller]

send me a PM that contains:
* a link to this thread
* an admin account

[Joachim Müller]

OK, I was able to replicate this issue both on your page as well as on a vanilla test gallery, so actually you have found a bug. Moving this thread to the bugs board. Please have a little patience to let the dev team figure out what is wrong.

Summary for the devs: when upload for registered users is allowed both to public and personal albums, and public upload approval is set to no, but personal gallery upload approval is set to yes, the pics uploaded to a personal gallery by that user are visible instantly without needing admin approval. Happnes both for bridged and unbridged installs.

[Stramm]

picmgmnt.inc.php

replace

Code Select Expand

    } elseif (!$USER_DATA['pub_upl_need_approval']) {
with

Code Select Expand

    } elseif (!$USER_DATA['pub_upl_need_approval'] && $category < FIRST_USER_CAT) {

[Joachim Müller]

[slightly off topic]

@Stramm: thanks for looking into this. Please review the dev-only posting http://forum.coppermine-gallery.net/index.php?topic=9118.msg137073#msg137073 . Imo you should have CVS access to be able to commit both this fix to stable and devel branch as well as some features from your modpack into the devel branch. Please do as suggested on the above mentioned thread and start a new thread in the dev-only section to discuss what features of your modpack should go into the future core of coppermine.

[/slightly off topic]