Highslide (Skip Intermediate Page and show full image )

[Sami]

New version released
@PYAP : Thank you for fast reply
@lontano : old italian lang file added to this pack , I'm waiting for your reply and thank you for tranlation
@rphMedia : Thanks man for suggestions , I hope it work on your custom theme
@Quinti : SEF compatibilty option added to this version but as I don't have SEF enabled , it's not tested , So i'm waiting for your confirmation

Hope you all enjoy this ...

[Pascal YAP]

Sami,

On new install, i receive an error from line 68 in french.php

Code Select Expand


Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')' in french.php on line 68
But my file had 66 lines  What'z the matter ?

PYAP

[Sami]

Sorry It was mine
Package updated
Download it again,

[Davide Renda]

@lontano : old italian lang file added to this pack , I'm waiting for your reply and thank you for tranlation

here attached the updated file - thank you!

[rphMedia]

@rphMedia : Thanks man for suggestions , I hope it work on your custom theme

OK Sami, we're getting closer

For my sample gallery, I don't have a js theme, but I do have 'lightbox plus....'

Works in Firefox perfectly --- It's respecting non-image types now

IE wants to open a browser window (same window). ((I eventually would like it to be cross-browser friendly))

Have no idea what IE does that Firefox doesn't.  More troubleshooting...

[Sami]

So plugin works withh FF and have issue with IE for you ?
Then try refresh with ctrl+f5 in case of cache issue

[rphMedia]

I wish it was that simple

I have the plugin installed at http://gallery.rphmedia.net if you'd like to explore.  Firefox is doing everything [correctly].  IE is missing something or ....

((I also tried it with the foliage theme (Gizmo's nice find) and your plugin fails miserably with that theme, but that's OK, I'd rather it work with the other visual mods))

I wish it would work with everything, but we can't have it all 

Still, good work Sami --------- take a break

[Sami]

Ron works for me in both FF and IE with classic theme , I'll check your default theme for JS conflict ...
btw it's better if you set the Slide should show on option to intermediate

[rphMedia]

Ron works for me in both FF and IE with classic theme

I know, it works with classic theme because I don't have lightbox (plus) included with that theme. 

I think I will bow out, because my problem is unique.  Like I said, I would just like all these great mods to work together.  I may be asking too much 

[Fabrian]

I had a little problem, though you should know as it's consistant.

I had two folders in the uploads directory that where missing underscores or dashes.  Even though highslide was set to show intermediate, it would still expand into the the full size image as if it were set that way..  I renamed the folders that had missing characters and it was fine again (basically if there were any "%" in the link path).

I thought it was me, because I'm usually doing this stuff late at night half asleep and make silly mistakes, but I checked the problem and resolution thoroughly before I posted.

[Sami]

can you post a direct link to those pictures ?
I know that you rename those folders but I want to check the whole url
and would you tell me the old name of those folders ?

[Sami]

@rphMedia :
I find a solution for you let's check it ...
open up your spica.js and comment out lines around 27 ~34 , final code should be like this

Code Select Expand


/*Array.prototype.indexOf = function(value,idx)
{
if (typeof(idx) != 'number') idx = 0;
else if (idx < 0) idx = this.length + idx;
for (var i=idx,n=this.length;i<n;i++)
if (this[i] === value) return i;
return -1;
}*/


I've no idea why IE reject HS plugin by setting this function but this way both lighbox plus and Highslide will work
Also check it with more browser for any other issue cause by commenting !

[rphMedia]

Getting even closer.  Now Firefox doesn't like the scripts. IE works good, both js's !

Firefox complaint -

Error: Browser is not a constructor
Source File: http://gallery.rphmedia.net/themes/blackbirch/js/spica.js
Line: 51

Error: Event.register is not a function
Source File: http://gallery.rphmedia.net/themes/blackbirch/js/lightbox_plus.js
Line: 593

I wish I knew Javascript a little better.  I know enough to get by 

[Sami]

The way you commenting that out is wrong
replace this:

Code Select Expand


if (!Array.prototype.indexOf)
/*{
Array.prototype.indexOf = function(value,idx)
{
if (typeof(idx) != 'number') idx = 0;
else if (idx < 0) idx = this.length + idx;
for (var i=idx,n=this.length;i<n;i++)
if (this[i] === value) return i;
return -1;
}
}*/

with this

Code Select Expand


if (!Array.prototype.indexOf)
{
/*Array.prototype.indexOf = function(value,idx)
{
if (typeof(idx) != 'number') idx = 0;
else if (idx < 0) idx = this.length + idx;
for (var i=idx,n=this.length;i<n;i++)
if (this[i] === value) return i;
return -1;
}*/
}


[rphMedia]

That did it Sami, you're a genius 

Both, your Plugin and Gizmo's Lightbox mod works perfect in all of the standard themes !  I think it's an outstanding alternative for viewing the CPG's.  So smooth and streamlined (and quiet, no annoying clicks).

Thanks ! & Keep Plugin 

[Fabrian]

can you post a direct link to those pictures ?
I know that you rename those folders but I want to check the whole url
and would you tell me the old name of those folders ?

Look here: http://thefabhouse.com/testcpg

The directory where the images sit were created, and then the pictures were batch added.  I'm mentioning this because I noticed, when I looked at the path highslide was using for the image, in the directory that has spaces, the image filename is what I named it before I uploaded.  In the directory that has no spaces, the image name has normal_ before the filename.  So it seems when the directory name has spaces, cpg is not creating an intermediate file when adding the pictures to an album.

[rphMedia]

I'm pretty sure that the conflict is with the foliage theme.

Check here, it works good with the classic theme -

http://www.thefabhouse.com/testcpg/?theme=classic

Unless I'm missing something.

EDIT: OK, I do see what you're saying now, but this doesn't have anything to do with the Highslide Plugin. That is a weird occurance.  "Could" be the server?

[Fabrian]

Unless I'm missing something.

Yes.  The default theme is set to Orange Sky anyway, I'm not sure why you're mentioning the foliage theme.  You should only see two files, with and without spaces.  Notice the expaned image...on my test gallery highslide is set to index only and not all images.

[Fabrian]

I'm pretty sure that the conflict is with the foliage theme.

Check here, it works good with the classic theme -

http://www.thefabhouse.com/testcpg/?theme=classic

Unless I'm missing something.

EDIT: OK, I do see what you're saying now, but this doesn't have anything to do with the Highslide Plugin. That is a weird occurance.  "Could" be the server?

I checked everything again, and I don't think it's server side, but I thought maybe with cpg.  I checked what files exist in both directories (with spaces and without spaces) and all three files are there in both (orig file,thumb and normal).  The problem I see is Highslide is choosing the full image for intermediate for the file in the "with spaces" directory and it's choosing the normal image for intermediate for the file in the "without spaces" directory. 

[rphMedia]

I would merely recommend not using spaces or any special characters in directories or filenames.  This is a long standing practice in order to avoid such problems.  Highslide is doing what it's supposed to 

Not trying to be difficult here at all.